Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDF and JSON versions generated using OWL-API #1110

Merged
merged 12 commits into from Oct 31, 2019
Merged

Conversation

@dr-shorthair
Copy link
Contributor

dr-shorthair commented Oct 2, 2019

Fixes #1100

@dr-shorthair dr-shorthair added this to the DCAT CR milestone Oct 2, 2019
@dr-shorthair dr-shorthair added this to To do in DCAT revision via automation Oct 2, 2019
davebrowning and others added 2 commits Oct 3, 2019
Copy link
Collaborator

riccardoAlbertoni left a comment

I have tried to upload these files on Protege 5.5.0, and they do not arise errors.

However, I've noticed that the following warning appears when loading dcat.rdf, dcat.jsonld

Illegal redeclarations of entities: reuse of entity http://www.w3.org/ns/dcat#theme in punning not allowed [DataProperty: theme, ObjectProperty: theme]

Such a warning is not present when loading dcat.ttl.
Should we get rid of this?

@riccardoAlbertoni

This comment has been minimized.

Copy link
Collaborator

riccardoAlbertoni commented Oct 15, 2019

In case we are considering to regenerate the rdf and json serializations to address my previous comment, I would suggest to do it after accepting the PR #1125 and #1127.

riccardoAlbertoni and others added 3 commits Oct 21, 2019
@andrea-perego

This comment has been minimized.

Copy link
Contributor

andrea-perego commented Oct 30, 2019

@riccardoAlbertoni said:

In case we are considering to regenerate the rdf and json serializations to address my previous comment, I would suggest to do it after accepting the PR #1125 and #1127.

Which is the status of this PR? I see both PRs #1125 and #1127 have been merged. Can be safely merge also this one?

@andrea-perego andrea-perego added editorial and removed bug labels Oct 30, 2019
@riccardoAlbertoni

This comment has been minimized.

Copy link
Collaborator

riccardoAlbertoni commented Oct 30, 2019

I think we might want to regenerate the JSON and RDF to include the changes made in PR #1125 and #1127. As far as I have understood no all the usual tools to convert are working as expected.

@dr-shorthair: It seems that you have figured out the right combination of tools, would you mind to taking care of this conversion?

@dr-shorthair

This comment has been minimized.

Copy link
Contributor Author

dr-shorthair commented Oct 31, 2019

OK - done.

@riccardoAlbertoni riccardoAlbertoni self-requested a review Oct 31, 2019
@riccardoAlbertoni riccardoAlbertoni merged commit b63f379 into gh-pages Oct 31, 2019
1 check passed
1 check passed
ipr PR deemed acceptable.
Details
DCAT revision automation moved this from To do to Done Oct 31, 2019
@davebrowning davebrowning deleted the dcat-issue1100 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DCAT revision
  
Done
4 participants
You can’t perform that action at this time.