Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy edits to section 7.4 #1119

Merged
merged 4 commits into from Oct 10, 2019
Merged

copy edits to section 7.4 #1119

merged 4 commits into from Oct 10, 2019

Conversation

@nicholascar
Copy link
Contributor

nicholascar commented Oct 8, 2019

Karen's edits.

Since Karen made the edits, consider me making the PR a review from me - I'm happy. Still need two others though.

Copy link
Contributor

rob-metalinkage left a comment

Copy edits in general improve the text and clean nits - good stuff

A small number of potential ambiguities have crept in we need to fix first:

suggests a data representation may conform to a single profile - but of course it may conform to all more general profiles as well

saying "specification or a profile" introduces a false dichotomy - by principles of reflexivity a specification is a profile of itself - and a profile is a specification by definition.

"list of conformant profiles" - its not profiles which are conformant so this is misleading - just "list of available profiles" is better,

"own definitions of conformance" is over-specific - many specifications will not explicitly "define" conformance - but instead refer to (or rely on implicitly) shared nations of conformance.

@nicholascar nicholascar requested a review from rob-metalinkage Oct 9, 2019
nicholascar and others added 3 commits Oct 10, 2019
@rob-metalinkage rob-metalinkage merged commit 02f538f into gh-pages Oct 10, 2019
1 check passed
1 check passed
ipr PR deemed acceptable.
Details
@rob-metalinkage rob-metalinkage deleted the kcoyle-copyedits branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.