Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to address the Dataset publications [RDSP] requirement #803

Merged
merged 15 commits into from May 11, 2019

Conversation

@agbeltran
Copy link
Member

commented Mar 6, 2019

@agbeltran agbeltran added the dcat label Mar 6, 2019
@davebrowning davebrowning added dcat and removed dcat labels Mar 14, 2019
@davebrowning davebrowning added this to the DCAT CR milestone Mar 14, 2019
@riccardoAlbertoni riccardoAlbertoni self-requested a review Mar 21, 2019
Copy link
Collaborator

left a comment

+1 to explicitly mention this property, but I think we should drop the domain for this property as we are borrowing it for Dublin Core and in the original dc term the domain is not dcat:Dataset.

@andrea-perego

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

I agree with @riccardoAlbertoni .

+1 from me as well to add this property.

@makxdekkers

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

+1 from me too

@agbeltran agbeltran marked this pull request as ready for review May 8, 2019
@agbeltran

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

As discussed today (https://www.w3.org/2019/05/08-dxwgdcat-minutes.html), this PR will be modified to:

  • move the property to dcat:Resource
  • add note to indicate that this is a special case of what is referred in the dcat:qualifiedRelation property
  • remove domain
  • add RDF example

Also:

  • add item on Change history section
  • propagate property in inherited properties lists
@agbeltran

This comment has been minimized.

…cat:Resource properties
Copy link
Contributor

left a comment

Thanks, @agbeltran . I would suggest 2 changes:

  1. Remove the reference to Issue #63 . Maybe a link to Issue #63 can be added to the NOTE saying that this is a new property etc.
  2. Add the relevant entry in the changelog
@andrea-perego andrea-perego changed the title Draft PR to address the Dataset publications [RDSP] requirement PR to address the Dataset publications [RDSP] requirement May 8, 2019
@dr-shorthair

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

  • add dct:isReferencedBy to the dcat.ttl RDF file - with the DCAT usage notes and definitions as annotations
agbeltran added 6 commits May 10, 2019
@agbeltran

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

This PR is ready now - note that the link to the example will only work when merged into the gh-pagesbranch.

correcting wrong link to doi
@dr-shorthair dr-shorthair dismissed andrea-perego’s stale review May 11, 2019

Requested changes have been made

@dr-shorthair dr-shorthair merged commit 161b166 into gh-pages May 11, 2019
1 check passed
1 check passed
ipr PR deemed acceptable.
Details
@dr-shorthair dr-shorthair deleted the agb-issue63 branch May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.