Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditContext: update the Canvas example and fix video link in the Explainer #361

Merged
merged 7 commits into from
Nov 15, 2021
Merged

EditContext: update the Canvas example and fix video link in the Explainer #361

merged 7 commits into from
Nov 15, 2021

Conversation

alexkeng
Copy link
Contributor

@alexkeng alexkeng commented Nov 9, 2021

This PR updates the Canvas example with the revised APIs, updateCharacterBounds(), and getTextFormats().

The link to the demo video in the Explainer is also fixed in this PR.

xfq
xfq reviewed Nov 10, 2021
View reviewed changes
docs/EditContext/explainer.md Outdated Show resolved Hide resolved
travisleithead
travisleithead approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@travisleithead travisleithead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. I didn't try to compile the JavaScript or anything, so may have a bug there or two, but can tweak that later if someone else notices...

@alexkeng alexkeng merged commit 78dd66b into w3c:gh-pages Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfq xfq xfq left review comments

@travisleithead travisleithead travisleithead approved these changes

@BoCupp-Microsoft BoCupp-Microsoft Awaiting requested review from BoCupp-Microsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkeng @travisleithead @xfq