Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to obfuscation #1980

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Updates to obfuscation #1980

merged 3 commits into from
Feb 4, 2022

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Jan 30, 2022

This PR makes the following changes:

  • creates a new "Limitations" section to separate the obfuscation introduction from the discussion of its drawbacks. Also extends the discussion a bit as per Obfuscation #1873
  • adds a caution box to rs spec about potential legal ramifications to match the caution in the core spec
  • reduces the requirement to deobfuscate to recommendation
  • harmonizes spelling of deobfuscation

Addresses #1873


Preview | Diff

add caution to rs spec about potential legal ramifications;
reduce requirement to deobfuscate to recommendation;
harmonize spelling of deobfuscation
Copy link
Contributor

@dauwhe dauwhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, in that it identifies the motivations for this as well as the limitations.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to ask Nick to review these changes, to see if this can be good enough to close #1873.

@dauwhe
Copy link
Contributor

dauwhe commented Feb 2, 2022

@npdoty does this look acceptable to you?

@mattgarrish mattgarrish merged commit 9738448 into main Feb 4, 2022
@mattgarrish mattgarrish deleted the editorial/issue-1873 branch February 4, 2022 01:28
@iherman
Copy link
Member

iherman commented Feb 4, 2022

The issue was discussed in a meeting on 2022-02-03

List of resolutions:

View the transcript

2. Updates to Obfuscation.

See github pull request epub-specs#1980.

See github issue epub-specs#1873.

Dave Cramer: this is the PR. There's a lot of discussion in the related issue..
… we've made a bunch of fixes to this.
… npd asked if we could explain harms of font obfuscation techniques, i.e., interop issues, opacity for end users inspecting what they are reading.
… but i've never had to inspect font file of epub i'm reading, so i'm not on board with that.
… could create liability for RS.
… but i'm not aware of legal issues, or threat of legal issues.

Brady Duga: i'm skeptical of even mentioning legal issues without explicit guidance from lawyers.
… even the caution that we're currently proposing, not sure what legal implications we are hinting at with that.
… if I was concerned about legal issues, I would consult my legal team rather than getting it from a spec.

Dave Cramer: i share this concern.

Matt Garrish: yeah, i struggled to come up with a caution that was meaningful.
… there was talk about DMCA.
… there are probably legal issues all over the place, so why pick just one.
… i'm not strongly in favor of this, so I would be okay with removal.
… stuff on content side is a little less controversial.

Dave Cramer: and some of the other limitations are legitimate.
… there can be real interop problems, etc..

Wendy Reid: +1 to general caution.

Brady Duga: i'm fine with the general caution.

Dave Cramer: mgarrish can you just remove the legal reference?.

Matt Garrish: yes.

Brady Duga: one other language issue about "designed to break the obfuscation".
… you're not breaking the obfuscation because its a well defined algorithm.

Wendy Reid: "deobfuscate".

Brady Duga: "intentionally make available"?.

Matt Garrish: agree.
… on the RS side, do we leave it as SHOULD, or should be go back to MUST support deobfuscation?.

Brady Duga: fine with having it as SHOULD support deobfuscation.

Dave Cramer: fine with leaving it at SHOULD, this is not a core feature.

Proposed resolution: Remove the legal reference from PR 1980, and merge 1980. (Wendy Reid)

Shinya Takami (高見真也): +1.

Wendy Reid: +1.

Toshiaki Koike: +1.

Matthew Chan: +1.

Brady Duga: +1.

Masakazu Kitahara: +1.

Dave Cramer: +1.

Resolution #2: Remove the legal reference from PR 1980, and merge 1980.

@iherman iherman mentioned this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants