-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to obfuscation #1980
Updates to obfuscation #1980
Conversation
add caution to rs spec about potential legal ramifications; reduce requirement to deobfuscate to recommendation; harmonize spelling of deobfuscation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, in that it identifies the motivations for this as well as the limitations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to ask Nick to review these changes, to see if this can be good enough to close #1873.
@npdoty does this look acceptable to you? |
The issue was discussed in a meeting on 2022-02-03 List of resolutions:
View the transcript2. Updates to Obfuscation.See github pull request epub-specs#1980. See github issue epub-specs#1873. Dave Cramer: this is the PR. There's a lot of discussion in the related issue.. Brady Duga: i'm skeptical of even mentioning legal issues without explicit guidance from lawyers. Dave Cramer: i share this concern. Matt Garrish: yeah, i struggled to come up with a caution that was meaningful. Dave Cramer: and some of the other limitations are legitimate.
Brady Duga: i'm fine with the general caution. Dave Cramer: mgarrish can you just remove the legal reference?. Matt Garrish: yes. Brady Duga: one other language issue about "designed to break the obfuscation". Wendy Reid: "deobfuscate". Brady Duga: "intentionally make available"?. Matt Garrish: agree. Brady Duga: fine with having it as SHOULD support deobfuscation. Dave Cramer: fine with leaving it at SHOULD, this is not a core feature.
|
This PR makes the following changes:
Addresses #1873
Preview | Diff