From d0f12a983c28ee79d76fd7d15609d5532cfb0028 Mon Sep 17 00:00:00 2001 From: Romain Deltour Date: Mon, 24 Jan 2022 04:03:40 +0100 Subject: [PATCH] feat: page-list nav does not have to match reading order This commit: - removes the call to check the page list reading order - keeps the checking code, as well as NAV-011 - update tests Fix #1237 --- src/main/java/com/adobe/epubcheck/opf/XRefChecker.java | 1 - src/test/resources/epub3/navigation-publication.feature | 6 ++---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/adobe/epubcheck/opf/XRefChecker.java b/src/main/java/com/adobe/epubcheck/opf/XRefChecker.java index 668bfcc75..63aa1853e 100755 --- a/src/main/java/com/adobe/epubcheck/opf/XRefChecker.java +++ b/src/main/java/com/adobe/epubcheck/opf/XRefChecker.java @@ -310,7 +310,6 @@ public void checkReferences() } } checkReadingOrder(tocLinks, -1, -1); - checkReadingOrder(pageListLinks, -1, -1); checkReadingOrder(overlayLinks, -1, -1); } diff --git a/src/test/resources/epub3/navigation-publication.feature b/src/test/resources/epub3/navigation-publication.feature index d77e2c89d..e5f3f9b11 100644 --- a/src/test/resources/epub3/navigation-publication.feature +++ b/src/test/resources/epub3/navigation-publication.feature @@ -71,14 +71,12 @@ Feature: EPUB 3 ▸ Navigation Document ▸ Full Publication Checks When checking EPUB 'nav-page-list-reading-order-valid' Then no errors or warnings are reported - Scenario: Report a `page-list nav` whose links do not match the spine order + Scenario: Verify a `page-list nav` whose links do not match the spine order When checking EPUB 'nav-page-list-unordered-spine-warning' - Then warning NAV-011 is reported And no other errors or warnings are reported - Scenario: Report a `page-list nav` whose links do match the document order + Scenario: Verify a `page-list nav` whose links do match the document order When checking EPUB 'nav-page-list-unordered-fragments-warning' - Then warning NAV-011 is reported And no other errors or warnings are reported