Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscores in the host part of URLs #1079

Closed
Mustaf2659 opened this issue Sep 13, 2019 · 8 comments
Closed

Allow underscores in the host part of URLs #1079

Mustaf2659 opened this issue Sep 13, 2019 · 8 comments

Comments

@Mustaf2659
Copy link

@Mustaf2659 Mustaf2659 commented Sep 13, 2019

While validate the ePub File the below URL showing error as "missing 1 slash(es) '/' after the protocol 'http:'", but the url link works fine.

<a href="http://encyclopedie_universelle.fracademic.com/65285"> http://encyclopedie_universelle.fracademic.com/65285 </a>

Please suggest how solve this issue.

@rdeltour
Copy link
Member

@rdeltour rdeltour commented Sep 13, 2019

At first sight this looks like the same issue as #1034, but I’m not 100% sure sine the URL you’re showing here looks right.

Would you be able to share a full EPUB file to help us reproduce the error?

@Mustaf2659
Copy link
Author

@Mustaf2659 Mustaf2659 commented Sep 13, 2019

Unable to share full ePub file, herewith attached Sample ePub Package with the URL link causing error in Checker

Sample.zip

@rdeltour
Copy link
Member

@rdeltour rdeltour commented Sep 13, 2019

thanks @Mustaf2659!

@rdeltour
Copy link
Member

@rdeltour rdeltour commented Sep 13, 2019

Ah, the issue comes from the use of the underscore character ('_') in the host name, which is disallowed.
Now, as most browsers will be able to reach the link, I'm wondering if EPUBCheck should be more permissive here.

@Mustaf2659
Copy link
Author

@Mustaf2659 Mustaf2659 commented Sep 13, 2019

Thanks @rdeltour for your information.

@rdeltour
Copy link
Member

@rdeltour rdeltour commented Sep 13, 2019

All things considered, I still think there is an issue here. EPUBCheck should not reject this URL, as the hyperlink works in most browsers.

I’m reopening the issue and changing its title for easier reference.

@rdeltour rdeltour reopened this Sep 13, 2019
@rdeltour rdeltour changed the title Error in ePub Checker 4.2.2 Allow underscore in the host part of URLs Sep 13, 2019
@rdeltour rdeltour changed the title Allow underscore in the host part of URLs Allow underscores in the host part of URLs Sep 13, 2019
@mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Sep 13, 2019

Ya, isn't the issue that you can't register domain names with underscores but you can create subdomains with them as the rules aren't often enforced?

It really shouldn't result in warnings, as there's no encoding fix to get around it that I know of and the author likely can't change the URL.

@Mustaf2659
Copy link
Author

@Mustaf2659 Mustaf2659 commented Jun 23, 2020

Hi @rdeltour and @mattgarrish,

Thanks for fixes in ePub checker 4.2.3, issue resolved.

Regards,
Mustafa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants