New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geometry] Editorial: Use separate entry points instead of ignore3D #218

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@zcorpan
Member

zcorpan commented Sep 1, 2017

Fixes #217.


cc @fserb @junov @smfr


This does not need new tests, but needs a corresponding change for HTML. I can do that but will wait for this to have an approved review.

@zcorpan zcorpan added the geometry-1 label Sep 1, 2017

@svgeesus svgeesus requested a review from domenic Sep 14, 2017

MXEBot pushed a commit to mirror/chromium that referenced this pull request Sep 21, 2017

Fernando Serboncini Commit Bot
DOMMatrix2DInit validate and fixup and DOMMatrix constructors
Specified by:
w3c/fxtf-drafts#218
Spec:
https://drafts.fxtf.org/geometry/

Bug: 759988
Change-Id: I359dd7a97d7a1f6e086e00e1475849d6bf912dab
Reviewed-on: https://chromium-review.googlesource.com/672669
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#503160}

zcorpan added a commit to whatwg/html that referenced this pull request Nov 4, 2017

Update how DOMMatrix is created from a dictionary
This follows w3c/fxtf-drafts#218 and should
have no normative difference.
@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan
Member

zcorpan commented Nov 4, 2017

HTML PR at whatwg/html#3199

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Nov 6, 2017

Member

@smfr OK to merge this?

Member

zcorpan commented Nov 6, 2017

@smfr OK to merge this?

zcorpan added a commit to whatwg/html that referenced this pull request Nov 17, 2017

Update how DOMMatrix is created from a dictionary
This follows w3c/fxtf-drafts#218 and should
have no normative difference.

@zcorpan zcorpan merged commit 8f6b49d into master Nov 17, 2017

@zcorpan zcorpan deleted the zcorpan/tweak-dommatrix2dinit branch Nov 17, 2017

zcorpan added a commit to whatwg/html that referenced this pull request Nov 17, 2017

Update how DOMMatrix is created from a dictionary
This follows w3c/fxtf-drafts#218 and should
have no normative difference.
@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Nov 17, 2017

Member

I've gone ahead and merged since everything was reviewed and ready, just needed someone to make the call.

Member

zcorpan commented Nov 17, 2017

I've gone ahead and merged since everything was reviewed and ready, just needed someone to make the call.

nareix pushed a commit to nareix/webrtc.third_party that referenced this pull request Mar 5, 2018

Fernando Serboncini Commit Bot
DOMMatrix2DInit validate and fixup and DOMMatrix constructors
Specified by:
w3c/fxtf-drafts#218
Spec:
https://drafts.fxtf.org/geometry/

Bug: 759988
Change-Id: I359dd7a97d7a1f6e086e00e1475849d6bf912dab
Reviewed-on: https://chromium-review.googlesource.com/672669
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Original-Commit-Position: refs/heads/master@{#503160}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 168b7e233cb709887c6599466c75961585fb75d3

@syncbot syncbot restored the zcorpan/tweak-dommatrix2dinit branch Jul 3, 2018

@plinss plinss deleted the zcorpan/tweak-dommatrix2dinit branch Jul 3, 2018

@syncbot syncbot restored the zcorpan/tweak-dommatrix2dinit branch Jul 3, 2018

@plinss plinss deleted the zcorpan/tweak-dommatrix2dinit branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment