Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fill-stroke] Rename 'stupid' in 'fallback' #338

Merged
merged 1 commit into from May 13, 2019

Conversation

@Zefling
Copy link
Contributor

commented May 12, 2019

No description provided.

@AmeliaBR
Copy link

left a comment

This fixes inconsistencies in the current text: the value is described as fallback elsewhere in the prose.

@AmeliaBR

This comment has been minimized.

Copy link

commented May 12, 2019

Marked as non substantive for IPR from ash-nazg.

@BigBadaboom

This comment has been minimized.

Copy link

commented May 13, 2019

There are also references to stupid in stroke-linejoin still

@FremyCompany

This comment has been minimized.

Copy link

commented May 13, 2019

@AmeliaBR Are there any implementation of this? Otherwise I can just go ahead and merge.

@AmeliaBR

This comment has been minimized.

Copy link

commented May 13, 2019

@FremyCompany There are definitely no implementations of a stupid value. That was just a placeholder in the spec because @tabatkins & @fantasai want to replace the SVG 1 definition of miter.

@BigBadaboom There aren't any other uses of stupid as a keyword in the source file. The other places in the generated file are created automatically.

@Zefling

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@AmeliaBR It's a placeholder, but currently the draft says stupid and fallback for the same value.
I have not change this description: “It's a stupid value, useful only because we didn't have the clip-at-miterlimit behavior in SVG1.” It's just for a better understanding.

@FremyCompany FremyCompany merged commit 0c8b5be into w3c:master May 13, 2019

1 check passed

ipr PR deemed acceptable as non-substantive by @AmeliaBR.
Details
@FremyCompany

This comment has been minimized.

Copy link

commented May 13, 2019

I merged it, no reason to risk someone implementing stupid as a keyword for SVG :) Can always be rebikesheded later if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.