From c4e8c2c90086ad77618b1506b6f8c798e51a3011 Mon Sep 17 00:00:00 2001
From: Scott O'Hara
Date: Fri, 3 Mar 2023 06:55:10 -0500
Subject: [PATCH 1/4] disallow aria-hidden on body element
related to https://github.com/w3c/aria/issues/1254
closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
---
index.html | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/index.html b/index.html
index 0b58e11c..08575425 100644
--- a/index.html
+++ b/index.html
@@ -802,7 +802,11 @@
Naming Prohibited
- Otherwise, global `aria-*` attributes.
+ Otherwise, global `aria-*` attributes
+
+ with the exception that authors MUST NOT specify the `aria-hidden` attribute on the
+ `body` element.
+
From f35434132150ca4ffe8f3abf335bf158c47e3d64 Mon Sep 17 00:00:00 2001
From: Scott O'Hara
Date: Fri, 3 Mar 2023 07:51:25 -0500
Subject: [PATCH 2/4] clarify rule
as `aria-hidden=false` doesn't seem to cause any problems, even per the note in ARIA to use with caution:
>At the time of this writing, aria-hidden="false" is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach.
let's limit this rule to just `aria-hidden=true`
---
index.html | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/index.html b/index.html
index 08575425..b0d4d8d9 100644
--- a/index.html
+++ b/index.html
@@ -804,8 +804,7 @@
Otherwise, global `aria-*` attributes
- with the exception that authors MUST NOT specify the `aria-hidden` attribute on the
- `body` element.
+ with the exception that authors MUST NOT specify `aria-hidden=true` on the `body` element.
From 08a3eacac494a2bb90b5ae7c15aad7cac2021785 Mon Sep 17 00:00:00 2001
From: Scott O'Hara
Date: Mon, 6 Mar 2023 09:23:17 -0500
Subject: [PATCH 3/4] changelog update
---
index.html | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/index.html b/index.html
index 98b3e58d..3a9555b5 100644
--- a/index.html
+++ b/index.html
@@ -63,13 +63,17 @@
the following substantive additions and/or corrections have been proposed:
+ -
+ 6 March 2023 - Addition:
+ Disallow `aria-hidden=true` on the `body` element.
+
-
13 February 2023 - Addition:
- update figure role allowances to include `doc-example`.
+ Update `figure` element role allowances to include `doc-example`.
-
07 November 2022 - Correction:
- Revisions to 'any role' term description.
+ Revisions to 'any role' term description.
-
14 July 2022 - Correction:
From 9b0009153c4fb86275ea46f6ace5f8d91a453226 Mon Sep 17 00:00:00 2001
From: Scott O'Hara
Date: Mon, 6 Mar 2023 09:35:39 -0500
Subject: [PATCH 4/4] call out that not all global attributes are allowed on
generic
---
index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/index.html b/index.html
index 3a9555b5..ab1e4dee 100644
--- a/index.html
+++ b/index.html
@@ -808,7 +808,7 @@
Otherwise, global `aria-*` attributes
- with the exception that authors MUST NOT specify `aria-hidden=true` on the `body` element.
+ allowed for the `generic` role, with the exception that authors MUST NOT specify `aria-hidden=true` on the `body` element.