Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow images for a better narrow layout #20

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@anssiko
Copy link
Member

commented Oct 30, 2017

CSS is hard.


Preview | Diff

@anssiko anssiko requested a review from dontcallmedom Oct 30, 2017

@@ -376,7 +376,7 @@
"#example-4">Example 4</a>, the file picker can be rendered as
presented below:
</p>
<p>
<p style="overflow: visible;">

This comment has been minimized.

Copy link
@dontcallmedom

dontcallmedom Oct 30, 2017

Member

I think you would want to use the overlarge class (see Sample use of TR design)

This comment has been minimized.

Copy link
@anssiko

anssiko Oct 31, 2017

Author Member

The overlarge class does not appear to work for this case, since I want the left margin of the image and the surrounding text blocks to be the same, and only overflow the right side of the image that does not fit within the viewport.

Using the overlarge class, the left margin of the image differs from that of the surrounding text blocks on various screen widths (depending on which media query kicks in).

I tried applying the class to both the container elements, and separately just to the image elements with similar results.

This comment has been minimized.

Copy link
@dontcallmedom

dontcallmedom Oct 31, 2017

Member

ok, then, LGTM :)

@anssiko anssiko merged commit cbd129e into gh-pages Oct 31, 2017

1 check passed

ipr PR deemed acceptable.
Details

@anssiko anssiko deleted the image-editorial branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.