This repository was archived by the owner on Jul 30, 2019. It is now read-only.
Fix discrepancies between HTML and ARIA in HTML specs #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the allowed roles and aria attributes for various elements to better match the ARIA in HTML specification.
chaals
suggested changes
Jan 3, 2018
Collaborator
chaals
left a comment
chaals
left a comment
There was a problem hiding this comment.
These changes all look good to me - thank you for this effort.
Would you please add an entry to the changes.include list noting that there was a significant update and pointing to this PR, to help external reviewers?
scottaohara
changed the title
Member
Author
|
Hi @chaals I updated the change.include per your request. Also, I spoke with @stevefaulkner this morning and I'm going to be adding in the missing I'll get those as part of this PR asap. |
chaals
approved these changes
Jan 8, 2018
add the DPub roles from ARIA in HTML
Member
Author
|
@stevefaulkner & @chaals I have added the DPub roles from ARIA in HTML spec to this PR. Unless there is anything else to add or any fixes/updates I need to make, I think this is set? Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue 894, I've reviewed each of the HTML elements and their allowed ARIA
roles &aria-*attributes and have made multiple updates to align the HTML spec with the information provided in the latest editor's draft of ARIA in HTML.