Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discrepancies between HTML and ARIA in HTML specs #1133

Merged
merged 3 commits into from Jan 14, 2018

Conversation

Projects
None yet
3 participants
@scottaohara
Copy link
Member

commented Jan 3, 2018

Based on issue 894, I've reviewed each of the HTML elements and their allowed ARIA roles & aria-* attributes and have made multiple updates to align the HTML spec with the information provided in the latest editor's draft of ARIA in HTML.

update spec to match ARIA in HTML
update the allowed roles and aria attributes for various elements to better match the ARIA in HTML specification.

@scottaohara scottaohara requested a review from stevefaulkner Jan 3, 2018

@chaals
Copy link
Collaborator

left a comment

These changes all look good to me - thank you for this effort.

Would you please add an entry to the changes.include list noting that there was a significant update and pointing to this PR, to help external reviewers?

@scottaohara scottaohara changed the title Update HTML spec to match ARIA in HTML spec Fix discrepancies between HTML and ARIA in HTML specs Jan 4, 2018

@scottaohara

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2018

Hi @chaals

I updated the change.include per your request.

Also, I spoke with @stevefaulkner this morning and I'm going to be adding in the missing dpub roles that are in the ARIA in HTML spec, but are not currently present in the HTML spec.

I'll get those as part of this PR asap.

@chaals

chaals approved these changes Jan 8, 2018

add DPub roles
add the DPub roles from ARIA in HTML
@scottaohara

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2018

@stevefaulkner & @chaals I have added the DPub roles from ARIA in HTML spec to this PR.

Unless there is anything else to add or any fixes/updates I need to make, I think this is set?

Thanks

@LJWatson LJWatson merged commit 22b2c47 into w3c:master Jan 14, 2018

1 check passed

ipr PR deemed acceptable.
Details

plehegar pushed a commit that referenced this pull request Jan 14, 2018

@scottaohara scottaohara deleted the scottaohara:issue-894-update-aria-in-html branch Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.