This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
add in canonical #1467
Merged
add in canonical #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add reference to canonical in [list of supported tokens](https://w3c.github.io/html/document-metadata.html#ref-for-supported-tokens) - add in reference to canonical in link type table, and add corresponding section of prose.
instead of separately updating two lists (one here and one in the supported tokens table), remove the incomplete list in favor of only updating the latter.
mtrootyy
reviewed
Jun 19, 2018
<code>dns-prefetch</code>, | ||
<{link/icon}>, | ||
<{link/next}>, | ||
<code data-x="rel-pingback">pingback</code>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove pingback
from the rel
attribute value of <link>
element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should do that as a different issue / PR. better to track things rather than get them all mixed together. Happy to have you open an issue about that though :)
chaals
reviewed
Jun 20, 2018
sections/semantics-links.include
Outdated
|
||
The <{link/canonical}> keyword indicates that the URL given by the <{links/href}> attribute | ||
is the preferred URL for the current document. Indicating the preferred URL helps search engines | ||
reduce duplicate content, as described in more detail in The Canonical Link Relation specification. <!-- todo ref link goes here --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
...specification [[!rfc6596]].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1392
Needs reference link to https://tools.ietf.org/html/rfc6596
This PR does not address some of the sub-issues mentioned in 1392, but specifically: