Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Update semantics-forms.include #834

Merged
merged 3 commits into from Mar 29, 2017
Merged

Update semantics-forms.include #834

merged 3 commits into from Mar 29, 2017

Conversation

stevefaulkner
Copy link
Contributor

removed code causing layout issues in example, fixes #831

removed code causing layout issues in example
@@ -1209,7 +1209,7 @@
<pre highlight="html">
&lt;form&gt;
&lt;table&gt;
&lt;caption&gt;Example &lt;<code>label</code>:gt;'s <code>for</code> attribute with &lt;<code>label</code>&gt;&lt;/caption&gt;
&lt;caption&gt;Example &lt;label:gt;'s for attribute with &lt;label&gt;&lt;/caption&gt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a typo on that line as well as the <code> tags... So the closing angle backet for the 1st label currently says :gt; and this should be replaced with &gt; (just before 's)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a colon after example, and "with label" seems totally redundant.

(Yes, this is nitpicking editorial comment…)

@@ -1209,7 +1209,7 @@
<pre highlight="html">
&lt;form&gt;
&lt;table&gt;
&lt;caption&gt;Example &lt;label&gt;'s for attribute with &lt;label&gt;&lt;/caption&gt;
&lt;caption&gt;Example, &lt;label&gt;'s for attribute&lt;/caption&gt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevefaulkner I think @chaals 's comment was to add a colon, but a comma was added instead... (unless the plan changed as you're in the f2f meeting together?). (btw I hope it is ok for me to comment this way).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agcolom it's great to comment like this.

I did mean a colon, but grammatical nits in the text of code examples are not that important, so I'll merge this and wait for someone else if they want to fix it further…

@chaals chaals merged commit 85ab9b5 into master Mar 29, 2017
arronei pushed a commit to arronei/html that referenced this pull request Apr 17, 2017
fix w3c#831 - editorial

removed code causing layout issues in example

* Update semantics-forms.include

fixed typo

* Update semantics-forms.include

tweaked as per @chaals comments
@LJWatson LJWatson deleted the stevefaulkner-patch-2 branch August 8, 2017 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label example has broken code layout
3 participants