Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @lineHeight in multiRowAlign and linePadding tests #167

Closed
palemieux opened this issue Feb 10, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@palemieux
Copy link
Contributor

commented Feb 10, 2016

To maintain EBU-TT-D compatibility and per #166 (comment), #styling-inline is not permitted in EBU-TT-D, and @lineHeight specification should be move from <body> to "baseStyle" <style> in the multiRowAlign and linePadding tests.

@palemieux palemieux added the bug label Feb 10, 2016

@palemieux palemieux self-assigned this Feb 10, 2016

@palemieux palemieux added this to the imsc1-cr4 milestone Feb 10, 2016

palemieux added a commit that referenced this issue Feb 10, 2016

@palemieux palemieux added the pr open label Feb 10, 2016

@palemieux palemieux modified the milestones: imsc1-cr4, imsc1-pr Feb 11, 2016

@nigelmegitt

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2016

Note that the change to add tts:lineHeight to <body> was introduced in 4fcb141 on 2016-01-29.

palemieux added a commit that referenced this issue Feb 12, 2016

Merge pull request #168 from w3c/issue-167
Address #167 (Fix lineHeight in EBU-TT-D examples)

@palemieux palemieux removed the pr open label Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.