Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs from examples (issue #225) #229

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
2 participants
@palemieux
Copy link
Contributor

commented May 17, 2017

Closes #225

@palemieux palemieux added this to the imsc1.0.1 CR milestone May 17, 2017

@palemieux palemieux self-assigned this May 17, 2017

@palemieux palemieux requested a review from nigelmegitt May 17, 2017

@nigelmegitt
Copy link
Contributor

left a comment

I'm not sure this has been done completely - please check my review comment @palemieux ?

<p xml:id="subtitle1" region="bottom" begin="00:00:00.000" end="00:00:30.000" style="paragraphStyle">
<span style="spanStyle">##Line gaps##</span><br/>
<span style="spanStyle">The quick </span><span style="spanStyleBig">brown</span><span style="spanStyle"> fox</span><br/>
<span style="spanStyle">jumps over the </span><span style="spanStyleSmall">lazy</span><span style="spanStyle"> dog</span><br/>

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt May 19, 2017

Contributor

This appears still to have white space at the end of the line - I thought the idea here is to remove that? Same on lines 11 and 14 though that has less impact.

This comment has been minimized.

Copy link
@palemieux

palemieux May 19, 2017

Author Contributor

The objective was to remove "tab" characters. I have not trimmed spaces, which should have no impact AFAIK.

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt May 25, 2017

Contributor

As discussed today, the purpose of this document is not to test behaviour with white space at the ends of lines so it should be removed.

This comment has been minimized.

Copy link
@palemieux

palemieux May 25, 2017

Author Contributor

See revised PR

@palemieux palemieux merged commit 6bfa107 into master May 30, 2017

@palemieux palemieux deleted the issue-0225-remove-tabs-from-examples branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.