Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required spaces between non-terminal components of styling and parameter attributes (issue #221) #230

Merged
merged 4 commits into from Jun 15, 2017

Conversation

Projects
None yet
4 participants
@palemieux
Copy link
Contributor

commented May 17, 2017

Closes #221

@palemieux palemieux added this to the imsc1.0.1 CR milestone May 17, 2017

@palemieux palemieux self-assigned this May 17, 2017

@palemieux palemieux changed the title Added explicit spaces in tts:aspectRatio and tts:activeArea definitions Added explicit spaces in tts:aspectRatio and tts:activeArea definitions (issue #221) May 17, 2017

@skynavga

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

First, I assume that the title of this issue is incorrect, and should say ittp:* and not tts:*. Secondly, this proposed change is clearly not required due to the language that appears in TTML1 6.2:

Unless explicitly stated otherwise, linear white-space (LWSP) must appear between adjacent non-terminal components of a TT Parameter value unless some other delimiter is permitted and used.

If you think IMSC1 does not include this language already by direct or indirect reference, then you can add such a reference; but it would be inconsistent to specify whitespace in these value expressions when TTML1 does not.

@skynavga skynavga self-requested a review May 17, 2017

@skynavga
Copy link
Contributor

left a comment

Change not required and detrimental to consistency between IMSC and TTML. See my prior comment in conversation.

@palemieux palemieux changed the title Added explicit spaces in tts:aspectRatio and tts:activeArea definitions (issue #221) Added explicit spaces in ttp:aspectRatio and tts:activeArea definitions (issue #221) May 18, 2017

@palemieux palemieux changed the title Added explicit spaces in ttp:aspectRatio and tts:activeArea definitions (issue #221) Added explicit spaces in ttp:aspectRatio and ttp:activeArea definitions (issue #221) May 18, 2017

@nigelmegitt

This comment has been minimized.

Copy link
Contributor

commented May 19, 2017

I don't agree with #230 (review) since the wording in TTML applies to ttp: namespace parameter attributes and this issue is about ittp: namespace parameter attributes.

Nevertheless I also don't agree with the proposed solution, and as discussed in yesterday's meeting, I think we need to refer to or possibly copy the parameter lwsp wording from TTML and make it apply to ittp: namespace attributes.

@palemieux palemieux changed the title Added explicit spaces in ttp:aspectRatio and ttp:activeArea definitions (issue #221) Required spaces between non-terminal components of styling and parameter attributes (issue #221) May 20, 2017

Changes made as requested

@tairt

This comment has been minimized.

Copy link
Contributor

commented May 21, 2017

48e95e4 and 18b0917 look good to me as solution of #221

@nigelmegitt
Copy link
Contributor

left a comment

I'd prefer the new wording to resolve the ambiguities we have observed in TTML1, or at worst duplicate them exactly.

<ul>
<li>Section 2.3 of [[!TTML1]] specifies conventions used in the XML representation of elements; and</li>

<li>as specified in Sections 6.2 and 8.2 of [[!TTML1]] and for values of attributes defined in the IMSC 1.0 Styling and IMSC 1.0 Parameter namespaces, linear white-space (LWSP) is present between adjacent non-terminal components, unless some other delimiter is permitted and used.</li>

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt May 22, 2017

Contributor

I think this is quite ambiguous wording, and it is not quite a duplication of the TTML1 §6.2 text (which is substantively identical to the same wording in §8.2):

Unless explicitly stated otherwise, linear white-space (LWSP) must appear between adjacent non-terminal components of a TT Parameter value unless some other delimiter is permitted and used.

Specifically:

  • does the "is present between adjacent non-terminal components" mean "must be present ..."?
  • does the "unless" mean that any time a delimiter is present no whitespace is permitted? If it does mean that, is that a correct interpretation of TTML1?

This should be resolved in a similar way to w3c/ttml2#315, and I would like it to be clear one way or the other.

Defer to TTML1 for LWSP between components of attribute values
Recommend not using LWSP between components of tts:fontFamily
Clarify LWSP in aspectRatio syntax
@palemieux

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2017

Revised PR assuming the Option 2 at w3c/ttml1#248 is selected

@palemieux palemieux merged commit 88e6ba2 into master Jun 15, 2017

@palemieux palemieux deleted the issue-0221-missing-spaces-in-syntax branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.