Fix differences of XML and images for fillLineGap + show line area boundaries #234
Conversation
- This one part of the solution for issue #233. - The combined picture of fillLineGap needs to be re-generated.
|
Since the image has been regenerated is this now complete @TairT ? |
|
@nigelmegitt @TairT provided two images, which now need to be combined into one. |
palemieux
changed the title
imsc1/spec/ttml-ww-profiles.html
Outdated
| @@ -1040,7 +1040,8 @@ | |||
|
|
|||
| <figcaption> | |||
| Illustrative rendition of the example immediately above with <code>itts:fillLineGap="true"</code> removed (left) or | |||
| preserved (right). Blue lines have been added to show the boundaries between line areas. | |||
| preserved (right). Blue lines have been added to show the <em>before-edge</em> and <em>after-edge</em> of each line | |||
| area, which are coincident for successive line areas. | |||
There was a problem hiding this comment.
Maybe reword this for clarity to "Blue lines have been added to show the vertical position of the before-edge and after-edge of adjacent line areas; those edges are coincident. The before-edge of the first line and the after-edge of the last line are omitted." ? Just trying to be absolutely clear about what we are showing or not showing here. Not a big deal for me.
There was a problem hiding this comment.
I like the original wording for the first part, but would add as Nigel proposed: "The before-edge of the first line and the after-edge of the last line are omitted."
There was a problem hiding this comment.
"The before-edge of the first line and the after-edge of the last line are omitted."
The last updated to the PR added these blue lines in the graphics.
There was a problem hiding this comment.
There's not enough contrast to see those blue lines at the top and bottom - I could not easily tell if they are there or not. So I would say either change the colours somehow so they are all visible or take them out and add the descriptive text - I would be fine with @TairT 's compromise in #234 (comment)
There was a problem hiding this comment.
@palemieux Thanks for changing the images and the text, both fine for me. Although the lines at top and bottom are less visible than the others, I could still see them, so it would work for me. If you take one of Nigels proposals that is also fine with me. Possibly the revised version would already work. I made bottom and top lines a bit thicker.
This one part of the solution for issue XML Example and corresponding renderings in pictures for itts:fillLineGap don't fit #233.
The combined picture of fillLineGap needs to be re-generated.