Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing variable definition in Object to RDF Conversion #277

Closed
kasei opened this issue Dec 23, 2019 · 4 comments
Closed

Missing variable definition in Object to RDF Conversion #277

kasei opened this issue Dec 23, 2019 · 4 comments

Comments

@kasei
Copy link

@kasei kasei commented Dec 23, 2019

Object to RDF Conversion step 13.1 says:

If rdfDirection is i18n-datatype, set datatype to the result of appending language and the value of @direction in item separated by an underscore ("_") to https://www.w3.org/ns/i18n#.

However, the language variable does not seem to be set prior this step.

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 23, 2019

It should just reverence the @language value in item, if any. Perhaps the following would solve this:

If rdfDirection is i18n-datatype, set datatype to the result of appending the value of @language in item, or the empty string ("") if there is no such value, with the value of @direction in item separated by an underscore (""`) to ..."

@gkellogg gkellogg added the wr:open label Dec 23, 2019
@gkellogg gkellogg added this to Discuss-Call in JSON-LD Management Dec 23, 2019
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 24, 2019

Agreed, your proposed text would solve this. But it gets a bit wordy and complex by trying to (I assume) avoid splitting out a new temporary variable declaration for "@language in item, or the empty string ('') if there is no such value".

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

@kasei see update in PR #286. Please indicate if this addresses the issue.

@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 26, 2019

@gkellogg looks good, thanks!

gkellogg added a commit that referenced this issue Dec 26, 2019
gkellogg added a commit that referenced this issue Dec 26, 2019
@gkellogg gkellogg moved this from Discuss-Call to Editorial work complete in JSON-LD Management Dec 27, 2019
@gkellogg gkellogg closed this Jan 10, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.