Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental variable override in Deserialize JSON-LD to RDF Algorithm 1.2 #281

Closed
kasei opened this issue Dec 24, 2019 · 2 comments
Closed

Accidental variable override in Deserialize JSON-LD to RDF Algorithm 1.2 #281

kasei opened this issue Dec 24, 2019 · 2 comments

Comments

@kasei
Copy link

@kasei kasei commented Dec 24, 2019

Deserialize JSON-LD to RDF Algorithm step 1.2 says:

Otherwise, initialize graph as an empty RdfGraph and add to dataset using its add method along with graph name for graphName.

The initialization of the graph variable here seems to conflict with the initialization in the enclosing loop of step 1, and its subsequent use in step 1.3.

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 24, 2019

@kasei see update in PR #286. Please indicate if this addresses the issue.

gkellogg added a commit that referenced this issue Dec 26, 2019
gkellogg added a commit that referenced this issue Dec 26, 2019
@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management Dec 26, 2019
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 30, 2019

@gkellogg looks good, thanks!

@gkellogg gkellogg closed this Jan 10, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.