Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify text on IRI Expansion in Expansion step 7 #309

Closed
kasei opened this issue Jan 8, 2020 · 4 comments
Closed

Clarify text on IRI Expansion in Expansion step 7 #309

kasei opened this issue Jan 8, 2020 · 4 comments

Comments

@kasei
Copy link

@kasei kasei commented Jan 8, 2020

Expansion step 7 should be explicit about how expansion happens for the entry keys of element:

If active context has a previous context , the active context is not propagated. If from map is undefined or false , and element does not contain an entry expanding to @value , and element does not consist of a single entry expanding to @id , set active context to previous context from active context , as the scope of a term-scoped context does not apply when processing new node objects .

(e.g. whether any of the four optional input variables passed to IRI Expansion.)

@gkellogg gkellogg added this to Editorial Work in JSON-LD Management Jan 10, 2020
@gkellogg gkellogg added the wr:open label Jan 10, 2020
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Jan 10, 2020

Yes, this is a bit sloppy, but following other patterns leads to excess verbosity. In retrospect, we might have created a glossary of abbreviations for such regular calls, since for keywords, IRI expansion always uses true for vocab, and by context uses the active context to do the expansion. A longer winded paragraph might read as follows:

If active context has a previous context, the active context is not propagated. If from map is undefined or false, and element does not contain an entry_ expanding to @value (using the IRI expansion algorithm, passing active context, that entry for value, and true for _vocab), and element does not consist of a single entry expanding to @id (using the IRI expansion algorithm, passing active context, that entry for value, and true for _vocab), set active context to previous context from active context, as the scope of a term-scoped context does not apply when processing new node objects.

Is that what you had in mind? Does that add clarity?

@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Jan 10, 2020

@gkellogg yes, something like that. Without going to look at the specifics of the expansion algorithm, I would not have been able to tell you that "for keywords, IRI expansion always uses true for vocab", so I've found this sort of explicit language useful where it appears elsewhere in the document.

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Jan 14, 2020

@kasei see if that text is clear, and we'll close this.

@gkellogg gkellogg moved this from Editorial Work to Editorial work complete in JSON-LD Management Jan 14, 2020
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Jan 14, 2020

@gkellogg looks good, thanks.

gkellogg added a commit that referenced this issue Jan 15, 2020
@gkellogg gkellogg closed this Jan 15, 2020
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.