Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toRdf tests for merging rootless base paths #103

Merged
merged 2 commits into from Jun 10, 2019

Conversation

Projects
None yet
4 participants
@fsteeg
Copy link
Contributor

commented Jun 3, 2019

This came up in an issue with jsonld-java:
jsonld-java/jsonld-java#232

See second bullet point in:
https://tools.ietf.org/html/rfc3986#section-5.2.3

@iherman

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Marked as non substantive for IPR from ash-nazg.

1 similar comment
@fsteeg

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Marked as non substantive for IPR from ash-nazg.

@BigBlueHat BigBlueHat requested a review from gkellogg Jun 3, 2019

@davidlehn

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

There is a similar jsonld.js issue. There are likely more tricky test cases and test variations that could be written to cover these issues.
digitalbazaar/jsonld.js#305.

@fsteeg

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Added a test case for a base URI with a trailing slash, which (according to my understanding of the second bullet point in https://tools.ietf.org/html/rfc3986#section-5.2.3) results in preserving the full base URI (the scenario in digitalbazaar/jsonld.js#305).

@fsteeg fsteeg changed the title Add `toRdf` tests for merging rootless base URL paths Add toRdf tests for merging rootless base paths Jun 7, 2019

@gkellogg
Copy link
Member

left a comment

My implementation currently fails as it doesn't doesn't handle tag:example as having an empty base path, but this seems to be the correct interpretation.

@gkellogg gkellogg merged commit 6ed130a into w3c:master Jun 10, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
ipr PR deemed acceptable as non-substantive by @fsteeg.
Details

fsteeg added a commit to fsteeg/jsonld-java that referenced this pull request Jun 11, 2019

Handle opaque/path-rootless base IRIs
Add new spec tests, remove custom tests

See:

jsonld-java#232
w3c/json-ld-api#103

fsteeg added a commit to fsteeg/jsonld-java that referenced this pull request Jun 11, 2019

Handle opaque/path-rootless base IRIs
Add new spec tests, remove custom tests

See:

jsonld-java#232
w3c/json-ld-api#103

rubensworks added a commit to rubensworks/relative-to-absolute-iri.js that referenced this pull request Jun 12, 2019

rubensworks added a commit to rubensworks/jsonld-streaming-parser.js that referenced this pull request Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.