Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event handler attributes (e.g. onsourceopen) to MediaSource, SourceBuffer and SourceBufferList #66

Closed
foolip opened this Issue Apr 22, 2016 · 15 comments

Comments

Projects
None yet
5 participants
@paulbrucecotton

This comment has been minimized.

Copy link

paulbrucecotton commented Apr 28, 2016

@jdsmith3000 and @wolenetz: How do we triage this issue? Is it V1 or VNext?

@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented Apr 28, 2016

Nice-to-have, not must-have is my initial opinion, given our triage process and our V1 schedule.
@foolip Can you provide an example where the currently missing MSE event handler attributes could be used for feature detection, where the existence of the MSE object (MediaSource, primarily) isn't sufficient? Such could help make a stronger case for inclusion of this issue into MSE v1.

@ddorwin

This comment has been minimized.

Copy link

ddorwin commented Apr 28, 2016

I could be wrong, but I thought these were discouraged unless they applied to declarable objects. For example, we removed most such handlers from EME when we switched to objects but left onencrypted because it is useful in the <video> tag.

@foolip

This comment has been minimized.

Copy link
Member Author

foolip commented Apr 28, 2016

@wolenetz The feature detection becomes relevant the first time you add an event that isn't currently supported. The existence of an onfoo attribute is normally the only way to detect that the foo event is implemented. It's not really relevant for v1, except that people may just assume that they exist.

@ddorwin What are declarable objects? There was a time when onfoo attributes were unfashionable, but now the norm seems to be to include them. Even something brand new like https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#service-worker-obj has it.

@ddorwin

This comment has been minimized.

Copy link

ddorwin commented Apr 28, 2016

@foolip

This comment has been minimized.

Copy link
Member Author

foolip commented Apr 28, 2016

FWIW, I'd make the same argument for EME, and can file an issue if you'd like.

@ddorwin

This comment has been minimized.

Copy link

ddorwin commented Apr 28, 2016

@ddorwin What are declarable objects?

I meant objects that can be defined declaratively.

There was a time when onfoo attributes were unfashionable, but now the norm seems to be to include them.

The bug above may have been during that time. Can we get definitive guidance from public-script-coord@ or similar?

FWIW, I'd make the same argument for EME, and can file an issue if you'd like.

I was just about to say the same thing. If the right thing to do is add them for MSE, we should also add them for EME. It probably makes sense to file an issue and note that it is blocked on resolution of this issue. Thanks.

@foolip

This comment has been minimized.

Copy link
Member Author

foolip commented Apr 28, 2016

Seems like something that https://w3ctag.github.io/design-principles/ might cover. @domenic @slightlyoff?

@domenic

This comment has been minimized.

Copy link

domenic commented Apr 28, 2016

Yeah, agreed we can try to include it there.

@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented Apr 28, 2016

If I understand correctly, there is no guidance around whether or not these handlers need attributes.
@domenic do you have a rough idea when there might be such guidance (probably in w3ctag/design-principles#29)? Both MSE and EME need it ASAP to be able to effectively triage this issue into V1 or VNext.

@wolenetz wolenetz added the blocked label Apr 28, 2016

@domenic

This comment has been minimized.

Copy link

domenic commented Apr 28, 2016

I gave some guidance in the w3ctag issue you opened.

@wolenetz wolenetz removed the blocked label Apr 28, 2016

@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented Apr 28, 2016

@domenic, thanks for the guidance. Based on w3ctag/design-principles#29 (comment), it looks like this is something that needs fixing in MSE v1 scope. @jdsmith3000 / @mwatson2, Do you agree this needs to be marked V1?

@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented Apr 28, 2016

We need to add:

  • Attributes for MediaSource events:
    • onsourceopen
    • onsourceended
    • onsourceclose
  • Attributes for SourceBuffer events:
    • onupdatestart
    • onupdate
    • onupdateend
    • onerror
    • onabort
  • Attributes for SourceBufferList events:
    • onaddsourcebuffer
    • onremovesourcebuffer
@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented May 4, 2016

@wolenetz

This comment has been minimized.

Copy link
Contributor

wolenetz commented May 10, 2016

1e4b68c fixes this. Closing.

*edited to reference the w3c, not wolenetz, repo for the commit.

@wolenetz wolenetz closed this May 10, 2016

dstockwell pushed a commit to dstockwell/chromium that referenced this issue Jun 29, 2016

wolenetz Commit bot
MSE: Add EventHandler attributes to MSE objects
Per intent [3], and due to recent spec change [1] for spec issue [2], this change adds
EventHandler attributes for MSE objects as follows:

Attributes for MediaSource events:
* onsourceopen
* onsourceended
* onsourceclose

Attributes for SourceBuffer events:
* onupdatestart
* onupdate
* onupdateend
* onerror
* onabort

Attributes for SourceBufferList events:
* onaddsourcebuffer
* onremovesourcebuffer

[1] w3c/media-source#75
[2] w3c/media-source#66
[3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dM_8nlXvJIE

R=mlamouri@chromium.org,rbyers@chromium.org,chcunningham@chromium.org
BUG=623678

Review-Url: https://codereview.chromium.org/1945523003
Cr-Commit-Position: refs/heads/master@{#402946}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 17, 2016

Bug 1286722: [MSE] P1. Add mediasource event handler attributes. r=bz
See w3c/media-source#66

MozReview-Commit-ID: 9fANabkz5ud

--HG--
extra : rebase_source : 37ef4885191942c56cc2ff0e198c5cbc7cab0c4a

lissyx pushed a commit to mozilla-b2g/gecko-tablet that referenced this issue Jul 17, 2016

jryans pushed a commit to jryans/gecko-dev that referenced this issue Jul 20, 2016

trav90 added a commit to trav90/Pale-Moon that referenced this issue Jun 19, 2017

janekptacijarabaci added a commit to janekptacijarabaci/Pale-Moon that referenced this issue Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.