Upstream codec switching (changeType) feature from WICG incubation spec #274
Conversation
Fixes a few typos, adds more clarifications.
Updates the README.md to outline the incubation purpose for this repository fork. Includes an inital list of current incubation branches (just codec-switching right now).
* Includes codec-switching mention in title and abstract. * Adds changeType() method and algorithm. * Updates segment parser loop to disallow a media segment immediately following changeType() (without intervening initialization segment). * Updates initialization segment received algorithm to allow for codec changes. * Updates Byte Stream Formats section's text around codec changes. * Updates media-source.js to include linkages for new definitions. * Includes a regenerated index.html.
Adds non-normative encouragement text.
Add support for codec switching using SourceBuffer.changeType()
Added link to upstream repo issue tracker
…ity and privacy To support TAG review, this change includes @wolenetz's answers for the w3ctag self-review questionnaire on security and privacy.
Updates the codec-switching explainer to match the incubation spec. Particularly, this change: 1) updates SourceBuffer.changeType(type) method description: it throws exception on synchronous error versus the initial proposal having it return a boolean. 2) includes links to implementation status and experimental web-platform-test results 3) indicates the routes chosen for each of the original proposal's "Open Questions and Thoughts"
See the w3c media-source repository for current work. Moving incubated features there is work-in-progress.
Pulls in the incubated codec-switching, aka changeType, specification from WICG fork. Strips out incubation boilerplate and unrelated pieces from the downstream codec-switching branch, and updates to the recently applied respec shorthand in upstream. The net result is that only media-source-respec.html is updated.
|
@tidoust - please review for respec and process correctness. Specifically, I used git merge to pull in the full downstream WICG incubation branch for this feature -- should the result, once through review, be landed in a different manner than "Squash and merge" to preserve more of the git history details? Also, while I did most of the editorial work for the feature in the WICG branch, there were a few other contributors -- if squashed when landing this, how can they be credited in that landed commit? @mwatson2 - this is a nontrivial feature addition to MSE. It has already been implemented and shipped in multiple user agents according to the incubation spec, so hopefully isn't controversial, but please do a co-editor review pass on this. Thank you both! |
There was a problem hiding this comment.
That looks good to me. See inline for one typo and a couple of editorial suggestions.
There are no specific W3C recommendations for managing the history of commits in Git. I would personally squash and merge to keep the history somewhat clean and readable, but that's up to you!
I do not have a magic solution to credit people automatically. You could mention them in the squashed commit message, and/or add them to the Acknowledgments section
Co-authored-by: François Daoust <fd@tidoust.net>
Co-authored-by: François Daoust <fd@tidoust.net>
Co-authored-by: François Daoust <fd@tidoust.net>
|
@wolenetz Looks good to me. Sorry for the delay. |
Merges remote-tracking branch 'wicg-upstream/codec-switching'
Pulls in the incubated codec-switching, aka changeType, specification
from WICG fork. Strips out incubation boilerplate and unrelated pieces
from the downstream codec-switching branch, and updates to the recently
applied respec shorthand in upstream. The net result is that only
media-source-respec.html is updated.
Multiple user agents have shipped this feature already, and web-platform
tests already exist for it. See w3c/mediasource/issues/155 (#155).
Preview | Diff