Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ended event a simple event #338

Closed
alvestrand opened this issue Apr 13, 2016 · 2 comments · Fixed by #341
Closed

Make ended event a simple event #338

alvestrand opened this issue Apr 13, 2016 · 2 comments · Fixed by #341
Assignees
@dontcallmedom
Labels
PR exists

Comments

@alvestrand
Copy link
Contributor

Per discussion in #337 the ErrorEvent is a problem in that it can't be implemented as specified, due to a name clash with HTML.

The only user of ErrrorEvent is to provide an optional error on the "ended" event; so far, nobody's suggested text that says when we would include such an error.

Suggestion: Make the "ended" event a simple event, and remove ErrorEvent from the spec.
There are no known implementations at the moment.
@alvestrand alvestrand mentioned this issue Apr 13, 2016
Closed
@stefhak
Copy link
Contributor

stefhak commented Apr 14, 2016

@alvestrand Your suggestion makes total sense IMO.

@elagerway elagerway assigned dontcallmedom and unassigned burnburn Apr 19, 2016
@elagerway
Copy link
Contributor

Dom has volunteered to submit a PR on this.

dontcallmedom added a commit that referenced this issue Apr 20, 2016
@dontcallmedom
Make ended event a simple event
36ba540 
close #338
@dontcallmedom dontcallmedom mentioned this issue Apr 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dontcallmedom dontcallmedom

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ended event a simple event w3c/mediacapture-main
5 participants
@dontcallmedom @alvestrand @burnburn @stefhak @elagerway