-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or rename 'volume' #585
Comments
Seems to not be implemented in Safari or Firefox at the moment. |
My interpretation of the spec is not that it is a multiplier applied to the samples, even though the word multiplier is used. I interpret that the value of the property is a value between 0 to 1 such that the value, when multiplied by a constant (or maybe a function) results in the actual volume, with 1 yielding the maximum value and 0 the minimum. |
Based on a chat with alvestrand, it was clarified that this constrainable property was meant to determine loss, more precisely an additional layer of processing on a track to lower the volume of the track. I am not sure about the initial intention and use-case for such a constraint, but it looks to me the constrainable property should either be removed or renamed. |
Shall we remove it? ;) |
+1 to remove it |
WebKit implements 'volume', but we won't object to removing it. |
seems that only Safari has implemented it, and don't object to removing it. |
Anything missing on the PR/bug? |
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: TODO(armax): file an i2d&r. [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: TODO(armax): file an i2d&r. [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881
@eric-carlson is there a WebKit bug tracking the removal of this? There's an Intent to Deprecate and Remove: volume property on blink-dev now, which ought to leave WebKit as the only engine supporting it. |
@foolip yes, I filed [MediaStream] remove 'volume' constraint |
Thanks Eric! |
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126}
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126}
…ting support for the 'volume' property., a=testonly Automatic update from web-platform-tests [MediaStreamTrack] Remove tests and existing support for the 'volume' property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126} -- wp5At-commits: e951b47b4c107995e7696ff9db7b2b0bafcde56b wpt-pr: 17028
…ting support for the 'volume' property., a=testonly Automatic update from web-platform-tests [MediaStreamTrack] Remove tests and existing support for the 'volume' property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126} -- wp5At-commits: e951b47b4c107995e7696ff9db7b2b0bafcde56b wpt-pr: 17028
… property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#664126}
I understand the intent here, but removal of this has caused a regression for us as we'd rely on this in order to normalize our comparative audio pipeline processing in Chrome. Since decision has been made to remove this, what are the other ways to read the microphone input gain for the developers? |
…ting support for the 'volume' property., a=testonly Automatic update from web-platform-tests [MediaStreamTrack] Remove tests and existing support for the 'volume' property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidouchromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Armando Miraglia <armaxchromium.org> Cr-Commit-Position: refs/heads/master{#664126} -- wp5At-commits: e951b47b4c107995e7696ff9db7b2b0bafcde56b wpt-pr: 17028 UltraBlame original commit: e092aed11b894bab9fe18ffd6b8910ddcdd220fc
…ting support for the 'volume' property., a=testonly Automatic update from web-platform-tests [MediaStreamTrack] Remove tests and existing support for the 'volume' property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidouchromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Armando Miraglia <armaxchromium.org> Cr-Commit-Position: refs/heads/master{#664126} -- wp5At-commits: e951b47b4c107995e7696ff9db7b2b0bafcde56b wpt-pr: 17028 UltraBlame original commit: e092aed11b894bab9fe18ffd6b8910ddcdd220fc
…ting support for the 'volume' property., a=testonly Automatic update from web-platform-tests [MediaStreamTrack] Remove tests and existing support for the 'volume' property. Since 'volume' has been removed from the standard specification[1], this CL removes support for the 'volume' from the output of MediaStreamTrack.getSettings(). Further, this CL removes the related existing tests. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8-Qn7pu41Kk [1] w3c/mediacapture-main#585 BUG=942016 Change-Id: I8cfcd5d119f79d4da73ee5aa94770f2cd2b7f881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630156 Reviewed-by: Guido Urdaneta <guidouchromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Armando Miraglia <armaxchromium.org> Cr-Commit-Position: refs/heads/master{#664126} -- wp5At-commits: e951b47b4c107995e7696ff9db7b2b0bafcde56b wpt-pr: 17028 UltraBlame original commit: e092aed11b894bab9fe18ffd6b8910ddcdd220fc
The 'volume' constrainable property is defined as being a multiplier applied to the linear audio samples. This means that this property does not control the volume of the audio device capture (which can be adjusted by the user and determined by the OS/HW) but rather the gain. More precisely, since the range allowed is between 0 and 1, this constrainable property controls the loss (gain between 0 and 1).
I propose that this property should be renamed from volume to either gain or loss.
Further, the description of volume in https://www.w3.org/TR/mediacapture-streams/#def-constraint-volume should be clearer in identifying it as gain/loss.
The text was updated successfully, but these errors were encountered: