Remove oldList and make it clear that groupId scope is the document #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henbos
reviewed
Sep 5, 2019
| @@ -2913,13 +2913,6 @@ <h2>Methods</h2> | |||
| <li> | |||
| <p>Let <var>resultList</var> be an empty list.</p> | |||
There was a problem hiding this comment.
Can we make "If [[storedDeviceList]] is not null, then let resultList be a copy of [[storedDeviceList]], and jump to the step labeled Complete Enumeration." say to do a deep copy instead of a copy?
There was a problem hiding this comment.
We could but this is not related to this particular issue.
This would partially fix #620.
|
This means that enumerateDevices always returns new objects, so object-equals is never true between two calls to enumerateDevices. |
|
WPT tests: web-platform-tests/wpt#19488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #604.
This hopefully makes it clear that a groupId is stable for the lifetime of a document.
Previously, if a device groupId was not in oldList/resultList, it would need to be regenerated.