Define MediaDevices.CaptureHandle #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidou
reviewed
Apr 7, 2021
index.html
Outdated
| agent of a meaningful {{MediaStreamTrack/label}} to apply to the | ||
| tracks that would result if the tab in which the application is | ||
| running is captured.<p> | ||
| <p>Only the top-level document may set or read this value. Attempts |
There was a problem hiding this comment.
Do you know if there are other ways for a doc to know if it's a top-level doc?
Anyway, I think saying that only the preferredLabel of the top-level document can be used as label would be enough. WDYT?
There was a problem hiding this comment.
I think window === window.top is an easier way for a document to check whether it's the top-level document, so we'd not be exposing that bit of information for the first time.
Your suggestion makes sense to me; I will enact the change.
eladalon1983
changed the title
eladalon1983
changed the title
|
This PR is out of date. I will produce a standalone document that more accurately reflects the direction this ended up taking. In the meantime, please see this explainer for what is currently in origin trial in Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a mechanism to allow an application to inform the user agent of what a meaningful label would be for the tracks that would result if the tab in which the application is running gets captured. Resolves #159.
Preview | Diff