Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduncancy and lack of normative clarity around interaction with constraints #28

Open
jan-ivar opened this issue Aug 8, 2019 · 1 comment

Comments

@jan-ivar
Copy link

commented Aug 8, 2019

This spec loosely mentions "Echo-cancellation", "noise suppression", and "boost intelligibility of the incoming signal" (autoGainControl?) and implies a control surface to those features.

There seems to be significant overlap here with track constraints. E.g.:

track.contentHint = "music";
await track.applyConstraints({
  echoCancellation: true,
  noiseSuppression: true,
  autoGainControl: true,
});
track.contentHint = "music";
console.log(track.getSettings().echoCancellation); // true or false?
console.log(track.getSettings().noiseSuppression); // true or false?
console.log(track.getSettings().autoGainControl);  // true or false?

My guess would be true on account of "These settings are not intended to replace encoder-level settings completely but rather complement them with a simpler hint"—even though we're not dealing with encoders here.

There also seems to be a missed opportunity here to make things normatively testable. E.g.:

// Assuming unconstrained track
track.contentHint = "music";
console.log(track.getSettings().echoCancellation); // false
console.log(track.getSettings().noiseSuppression); // false
console.log(track.getSettings().autoGainControl);  // false

The lack of testable steps feels like a general problem, so I'll open a separate issue on that.

@aboba

This comment has been minimized.

Copy link

commented Aug 9, 2019

Related Issue (for video): #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.