Skip to content

Section 2: DTLS Transport Issues #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aboba opened this issue Jun 20, 2014 · 3 comments
Closed

Section 2: DTLS Transport Issues #100

aboba opened this issue Jun 20, 2014 · 3 comments

Comments

@aboba
Copy link
Contributor

aboba commented Jun 20, 2014

Section 2.2. Constructor of DtlsTransport. When a DtlsTransport is automatically constructed, the UA cannot create an internal IceTransport without a given IceOptions. So, we need RTCIceTransport on the Constructor. The RTCIceTransport should not be ‘optional’ on the constructor.

Section 2.3. DtlsTransport. When DtlsTransport is closed, calling start() will start a new session (with new key negotiations, etc.). This should be specified in the spec – for the start() method.

Section 2.3. DtlsTransport. When “error” should be fired? What we’d like to propose: If the transport is closed without either party calling stop(), the UA should fire an error event.

@aboba
Copy link
Contributor Author

aboba commented Jun 20, 2014

Issues above are from Shijun Sun. Another one:

When invalid remote-params as input to DtlsTransport.start(), UA should throw an “Invalid Access Exception”.

@aboba
Copy link
Contributor Author

aboba commented Jun 20, 2014

Section 2.2 should say: "A RTCDtlsTransport instance is optionally constructed with an RTCIceTransport object."

change: readonly attribute RTCIceTransport transport;
to: readonly attribute RTCIceTransport? transport; //defaulted to null if constructor doesn't have it.

change: void addTransport (RTCIceTransport transport, int index = null);
to: void addTransport (RTCIceTransport transport, unsigned long? index = null);
change: void setTransport (RTCIceTransport transport);
to: void setTransport (RTCIceTransport? transport = null);

@aboba
Copy link
Contributor Author

aboba commented Jun 27, 2014

If RTCDtlsTransport.setTransport is removed as was discussed at the June 24 ORTC CG meeting, then if RTCIceTransport is not provided within the constructor there would be no way to add it later. So it cannot be optional in the constructor. Also, the transport attribute cannot be nullable.

Should an invalid parameter to start() throw an InvalidParameter exception?

Other proposed changes seem reasonable.

@aboba aboba closed this as completed Jun 28, 2014
robin-raymond pushed a commit to robin-raymond/ortc that referenced this issue Jul 16, 2014
…3c#66

Added Identity support, as described in Issue w3c#78
Reworked getStats method, as described in Issue w3c#85
Removed ICE restart method described in Issue w3c#93
Addressed CNAME and synchronization context issues described in Issue w3c#94
Fixed WebIDL issues noted in Issue w3c#97
Addressed NITs described in Issue w3c#99
DTLS transport issues fixed as described in Issue w3c#100
ICE transport issues fixed as described in Issue w3c#101
ICE transport controller fixes made as described in Issue w3c#102
Sender and Receiver object fixes made as described in Issue w3c#103
Fixed RTCRtpEncodingParameter default issues described in Issue w3c#104
Fixed 'Big Picture' issues descibed in Issue w3c#105
Fixed RTCRtpParameter default issues described in Issue w3c#106
Added a multi-stream capability, as noted in Issue w3c#108
Removed quality scalability capabilities and parameters, as described in Issue w3c#109
Added scalability examples as requested in Issue w3c#110
Addressed WebRTC 1.0 Data Channel compatibility issue described in Issue w3c#111
Removed header extensions from RTCRtpCodecParameters as described in Issue w3c#113
Addressed RTP/RTCP non-mux issues with IdP as described in Issue w3c#114
Added getParameter methods to RTCRtpSender and RTCRtpReceiver objects, as described in Issue w3c#116
Added layering diagrams as requested in Issue w3c#117
Added a typedef for payload type, as described in Issue w3c#118
Moved onerror from the RTCIceTransport object to the RTCIceListener object as described in Issue w3c#121
Added explanation of Voice Activity Detection (VAD), responding to Issue w3c#129
Clarified the meaning of maxTemporalLayers and maxSpatialLayers, as noted in Issue w3c#130
Added RFC 6051 to the list of header extensions and removed RFC 5450, as noted in Issue w3c#131
Addressed ICE terminology issues, as described in Issue w3c#132
Separated references into Normative and Informative, as noted in Issue w3c#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant