New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior when encodings are not set #187

Closed
aboba opened this Issue Apr 8, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@aboba
Copy link
Contributor

aboba commented Apr 8, 2015

It is possible for receiver.receive(parameters) or sender.send(parameters) to be called with parameter.encodings not set. What happens then?

@aboba aboba added the 1.1 label Apr 8, 2015

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Apr 15, 2015

Here is a proposal:

When parameters.encodings is not set when calling receiver.receive(parameters), then when an incoming packet matches a pt_table[packet.pt] entry, then an ssrc_table[] entry is added, but the pt_table[] entry is not removed. The default values of RTCRtpEncodingParameters (e.g. active = true) are assumed.

When parameters.encodings is not set when calling sender.send(parameters), then the browser chooses an SSRC for the sender, otherwise the default values of RTCRtpEncodingParameters are assumed.

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Jan 6, 2016

How about adding the following text to send() (Section 5.3.2):

"if parameters.encodings is unset, the user agent behaves as though a single encodings[0] entry was provided, with encodings[0].ssrc set to a value determined by the user agent, encodings[0].active set to "true", encodings[0].codecPayloadType set to codecs[j].payloadType where j is the first codec that is not "red", "rtx", "dtmf", "cn" or a forward error correction codec, and all the other encodings[0] attributes (e.g. fec, rtx, priority, maxBitrate, minQuality, resolutionScale,etc.) unset."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment