Behavior when encodings are not set #187

Closed
aboba opened this Issue Apr 8, 2015 · 2 comments

Projects

None yet

1 participant

@aboba
Contributor
aboba commented Apr 8, 2015

It is possible for receiver.receive(parameters) or sender.send(parameters) to be called with parameter.encodings not set. What happens then?

@aboba aboba added the 1.1 label Apr 8, 2015
@aboba
Contributor
aboba commented Apr 15, 2015

Here is a proposal:

When parameters.encodings is not set when calling receiver.receive(parameters), then when an incoming packet matches a pt_table[packet.pt] entry, then an ssrc_table[] entry is added, but the pt_table[] entry is not removed. The default values of RTCRtpEncodingParameters (e.g. active = true) are assumed.

When parameters.encodings is not set when calling sender.send(parameters), then the browser chooses an SSRC for the sender, otherwise the default values of RTCRtpEncodingParameters are assumed.

@aboba
Contributor
aboba commented Jan 6, 2016

How about adding the following text to send() (Section 5.3.2):

"if parameters.encodings is unset, the user agent behaves as though a single encodings[0] entry was provided, with encodings[0].ssrc set to a value determined by the user agent, encodings[0].active set to "true", encodings[0].codecPayloadType set to codecs[j].payloadType where j is the first codec that is not "red", "rtx", "dtmf", "cn" or a forward error correction codec, and all the other encodings[0] attributes (e.g. fec, rtx, priority, maxBitrate, minQuality, resolutionScale,etc.) unset."

@aboba aboba added a commit that referenced this issue Jan 6, 2016
@aboba aboba send(parameters) behavior when parameters.encodings is unset
Partial fix for Issue #187
b9430c7
@aboba aboba added PR exists and removed to-do-next-draft labels Jan 6, 2016
@aboba aboba closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment