New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority calculation not possible without knowing component #188

Closed
robin-raymond opened this Issue Apr 11, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@robin-raymond
Copy link
Contributor

robin-raymond commented Apr 11, 2015

https://tools.ietf.org/html/rfc5245#section-4.1.2.1

   priority = (2^24)*(type preference) +
              (2^8)*(local preference) +
              (2^0)*(256 - component ID)

The trouble is that the gatherer will start gathering on construction and reporting candidates. The trouble is the priority cannot be calculated as per recommendation because the component ID is not known upon construction. Associated RTCP based gatherers are passed into the start method for a transport created by "createAssociatedTransport()" but the gatherer is not specifically an RTCP based gatherer.

@robin-raymond robin-raymond added the 1.1 label Apr 11, 2015

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Apr 12, 2015

One way to fix this would be to add a .createAssociatedGatherer() method to the IceGatherer, which would return an IceGatherer object with a component attribute of RTCP.

partial interface RTCIceGatherer {
    readonly    attribute RTCIceComponent component;
    RTCIceGatherer createAssociatedGatherer ();
};

@aboba aboba added the PR exists label Apr 19, 2015

robin-raymond pushed a commit that referenced this issue May 7, 2015

Robin Raymond
- sender.setTrack() updated to return a Promise, as noted in:
#148

- Clarified handling of incoming connectivity checks prior to calling iceTransport.start(), as noted in:
#170

- Clarified handling of incoming DTLS packets, as noted in:
#173

- Added RTCIceGatherer as an optional argument to the RTCIceTransport constructor, as noted in:
#174

- Clarified handling of contradictory RTP/RTCP multiplexing settings, as noted in:
#185

- Clarified error handling relating to RTCIceTransport, RTCDtlsTransport and RTCIceGatherer objects in the "closed" state, as noted in:
#186

- Added component method and createAssociatedGatherer() method to the RTCIceGatherer object, as noted in:
#188

- Added close() method to the RTCIceGatherer object as noted in:
#189

- Clarified behavior of TCP candidate types, as noted in:
#190

- Clarified behavior of iceGatherer.onlocalcandidate, as noted in:
#191

- Updated terminology in Section 1.1 as noted in:
#193

- Updated RTCDtlsTransportState definitions, as noted in:
#194

- Updated RTCIceTransportState definitions, as noted in:
#197

@aboba aboba closed this May 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment