Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCIceTransport cannot go to "completed" state #191

Closed
robin-raymond opened this issue Apr 18, 2015 · 2 comments
Closed

RTCIceTransport cannot go to "completed" state #191

robin-raymond opened this issue Apr 18, 2015 · 2 comments
Labels
1.1 PR exists

Comments

@robin-raymond
Copy link
Contributor

We have no way to tell an IceTransport the remote gather will not generate any more candidates so it's not possible for an IceTransport to go to the "completed" state. While an IceTransport's "completed" state could mean "there are no better candidate pairs available at this time unless more are remotely trickled", it's redefining the purpose of the traditional IceTransport "completed" state.
@robin-raymond
Copy link
Contributor Author

Correction, there is an RTCIceCandidateComplete dictionary. But the exact conditions and functioning of the candidate are not clear. We need more text around it's usage.

@robin-raymond
Copy link
Contributor Author

On the RTCIceGatherer.onlocalcandidate, we should include:

When the final candidate is gathered, an RTCIceGatherer.onlocalcandidate event occurs with a RTCIceCandidateComplete emitted.

On the RTCIceTransport.addRemoteCandidate, we should include:

When the remote RTCIceGatherer emits its final candidate, the local RTCIceTransport.addRemoteCandidate should be called with an RTCIceCandidateComplete dictionary being passed in so that the local RTCIceTransport can know there are no more remote candidates expected and the local RTCIceTransport can therefor go enter into the completed state.

@aboba aboba closed this as completed Apr 26, 2015
robin-raymond pushed a commit that referenced this issue May 7, 2015
- sender.setTrack() updated to return a Promise, as noted in:
c006197 
#148

- Clarified handling of incoming connectivity checks prior to calling iceTransport.start(), as noted in:
#170

- Clarified handling of incoming DTLS packets, as noted in:
#173

- Added RTCIceGatherer as an optional argument to the RTCIceTransport constructor, as noted in:
#174

- Clarified handling of contradictory RTP/RTCP multiplexing settings, as noted in:
#185

- Clarified error handling relating to RTCIceTransport, RTCDtlsTransport and RTCIceGatherer objects in the "closed" state, as noted in:
#186

- Added component method and createAssociatedGatherer() method to the RTCIceGatherer object, as noted in:
#188

- Added close() method to the RTCIceGatherer object as noted in:
#189

- Clarified behavior of TCP candidate types, as noted in:
#190

- Clarified behavior of iceGatherer.onlocalcandidate, as noted in:
#191

- Updated terminology in Section 1.1 as noted in:
#193

- Updated RTCDtlsTransportState definitions, as noted in:
#194

- Updated RTCIceTransportState definitions, as noted in:
#197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.1 PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond