New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataChannel: short vs. long data types #231

Closed
aboba opened this Issue Aug 31, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@aboba
Copy link
Contributor

aboba commented Aug 31, 2015

From Robin Raymond:

dictionary RTCDataChannelParameters {
DOMString label = "";
boolean ordered = true;
unsigned short maxPacketLifetime;
unsigned short maxRetransmits;
DOMString protocol = "";
boolean negotiated = false;
unsigned short id;
};
unsigned short maxPacketLifetime;
unsigned short maxRetransmits;
^ those aren’t shorts (16 bits), they are 32 bit in the wire protocol

robin-raymond pushed a commit that referenced this issue Sep 21, 2015

Robin Raymond
Added support for the WebRTC 1.0 certificate management API, as noted…
… in: Issue #195

Added certificate argument to the RTCDtlsTransport constructor, as noted in: Issue #218
Added the "failed" state to RTCDtlsTransportState, as noted in: Issue #219
Changed getNominatedCandidatePair to getSelectedCandidatePair, as noted in: Issue #220
Added support for WebRTC 1.0 RTCIceCredentialType, as noted in: Issue #222
Clarified behavior of createAssociatedGatherer(), as noted in: Issue #223
Changed spelling from "iceservers" to "iceServers" for consistency with WebRTC 1.0, as noted in: Issue #225
Added support for SCTP port numbers, as noted in: Issue #227
Changed "outbound-rtp" to "outboundrtp" within the Statistics API, as noted in: Issue #229
Changed maxPacketLifetime and maxRetransmits from unsigned short to unsigned long, as noted in: Issue #231
Clarified DataChannel negotiation, as noted in: Issue #233
Added getContributingSources() method, as noted in: Issue #236
Fixes to Examples 5 and 6, as noted in: Issue 237 and Issue #239
Fixed cut and paste errors in Example 11, as noted in: Issue #241

@aboba aboba closed this Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment