Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in Example #248

Closed
Jxck opened this issue Sep 28, 2015 · 1 comment
Closed

typo in Example #248

Jxck opened this issue Sep 28, 2015 · 1 comment

Comments

@Jxck
Copy link
Contributor

@Jxck Jxck commented Sep 28, 2015

at https://github.com/openpeer/ortc/blob/master/ortc.html#L2460-L2463

// Create the sender and receiver objects
var audioSender = new RtpSender(audioTrack, audioRtpDtlsTransport, audioRtcpDtlsTransport);
var videoSender = new RtpSender(videoTrack, videoRtpDtlsTransport, videoRtcpDtlsTransport);
var audioReceiver = new RtpReceiver(audioRtpDtlsTransport, audioRtcpDtlsTransport);
var videoReceiver = new RtpReceiver(videoRtpDtlsTransport, videoRtcpDtlsTransport);

RtpXXXer seems typo, but RTCRtpXXXer seems correct.

@aboba
Copy link
Contributor

@aboba aboba commented Sep 28, 2015

Fixed.

robin-raymond pushed a commit that referenced this issue Oct 6, 2015
#240

- Fixed typos in Example 11, as noted in:
#241
#248

- Added text relating to RTCDataChannel exceptions and errors, as noted in:
#242

- Reconciliation of RTCRtpEncodingParameters dictionary with WebRTC 1.0, as noted in:
#249
@aboba aboba closed this Oct 6, 2015
Jxck added a commit to Jxck/ortc that referenced this issue Oct 15, 2015
w3c#240

- Fixed typos in Example 11, as noted in:
w3c#241
w3c#248

- Added text relating to RTCDataChannel exceptions and errors, as noted in:
w3c#242

- Reconciliation of RTCRtpEncodingParameters dictionary with WebRTC 1.0, as noted in:
w3c#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants