Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opus and other codec specific parameters #258

Closed
robin-raymond opened this issue Oct 25, 2015 · 4 comments
Closed

Opus and other codec specific parameters #258

robin-raymond opened this issue Oct 25, 2015 · 4 comments
Labels
1.0 compatibility issue 1.1 PR exists

Comments

@robin-raymond
Copy link
Contributor

We have codec specific capabilities listed (e.g. opus, vp8, H264):
http://ortc.org/wp-content/uploads/2015/10/ortc.html#opus-codec-capabilities*

But we have no such table(s) for codec parameters...

We need to list out exact parameters that an engine is expected to support.

Also for RTX / FEC codecs too (if applicable)...
@aboba
Copy link
Contributor

aboba commented Oct 25, 2015

The text states that the capabilities and parameters are the same.

@robin-raymond
Copy link
Contributor Author

Is this always true that they are identical?

@robin-raymond
Copy link
Contributor Author

A: No, they are not the same always thus capabilities and settings should be distinct entries. Also important to define is this is a sender cap/receiver cap and/or sender param/receiver param for each.

@robin-raymond
Copy link
Contributor Author

VP8 is currently a capability parameter, should also be a codec parameter (just like Opus)
H264 ^^^^

i.e. COPY them to codec parameters, and make it sender/receiver labelled

@aboba aboba mentioned this issue Nov 9, 2015
Merged
@aboba aboba mentioned this issue Nov 19, 2015
Merged
@aboba aboba removed the PR exists label Nov 20, 2015
@aboba aboba mentioned this issue Dec 1, 2015
Merged
aboba added a commit that referenced this issue Dec 8, 2015
@aboba
Cleanup of Opus settings
8d0f394 
#258

Changes: 
Removed stereo and spropStero settings (can be handled by channels)
Removed maxAverageBitrate (can be handled via maxBitrate)
This was referenced Dec 8, 2015
Merged
Merged
@aboba aboba added the PR exists label Dec 9, 2015
@aboba aboba closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 compatibility issue 1.1 PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond