New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opus and other codec specific parameters #258

Closed
robin-raymond opened this Issue Oct 25, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@robin-raymond
Copy link
Contributor

robin-raymond commented Oct 25, 2015

We have codec specific capabilities listed (e.g. opus, vp8, H264):
http://ortc.org/wp-content/uploads/2015/10/ortc.html#opus-codec-capabilities*

But we have no such table(s) for codec parameters...

We need to list out exact parameters that an engine is expected to support.

Also for RTX / FEC codecs too (if applicable)...

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Oct 25, 2015

The text states that the capabilities and parameters are the same.

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Oct 25, 2015

Is this always true that they are identical?

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Oct 28, 2015

A: No, they are not the same always thus capabilities and settings should be distinct entries. Also important to define is this is a sender cap/receiver cap and/or sender param/receiver param for each.

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Nov 9, 2015

VP8 is currently a capability parameter, should also be a codec parameter (just like Opus)
H264 ^^^^

i.e. COPY them to codec parameters, and make it sender/receiver labelled

@aboba aboba added PR exists and removed publication-blocker labels Nov 10, 2015

@aboba aboba removed the PR exists label Nov 20, 2015

aboba added a commit that referenced this issue Dec 8, 2015

Cleanup of Opus settings
#258

Changes: 
Removed stereo and spropStero settings (can be handled by channels)
Removed maxAverageBitrate (can be handled via maxBitrate)

@aboba aboba added the PR exists label Dec 9, 2015

@aboba aboba closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment