New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTX codec parameters, i.e. RTX-time #259

Closed
robin-raymond opened this Issue Oct 25, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@robin-raymond
Copy link
Contributor

robin-raymond commented Oct 25, 2015

If a receiver is configured to "latch all", i.e. no encoding parameters listed and an RTX codec is listed, how does the receiver know the RTX-time since that is only specified currently within the encoding parameters?

@robin-raymond robin-raymond added the 1.1 label Oct 25, 2015

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Oct 26, 2015

Should we add rtxTime as a parameter of the RTX codec?

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Oct 28, 2015

for RTX codec, we need optional param ulong CodecParameters.parameters.rtxTime

From RTC:

      indicates the time in milliseconds (measured from the
      time a packet was first sent) that the sender keeps an RTP packet
      in its buffers available for retransmission.

Also, inside EncodingParameters.rtx we need a mandatory EncodingParameters.rtx.codecPayloadType which points to the codec from the CodecParameters list to use for RTX when RTX is enabled. NOTE: Alternatively, it can be made optional and the engine can 'guess' the codecPayloadType based upon only one match existing with the same Hz rate as the main codec. If multiple matches exist though it would be an exception.

EncodingParameters.rtx.rtxTime is not required because the rtxTime should be taken from the CodecParameters.parameters.rtxTime where the rtx.codecPayloadType points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment