Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDegradationPreference #262

Closed
aboba opened this issue Oct 30, 2015 · 1 comment
Closed

RTCDegradationPreference #262

aboba opened this issue Oct 30, 2015 · 1 comment

Comments

@aboba
Copy link
Contributor

@aboba aboba commented Oct 30, 2015

In the June 2015 Editor's draft, RTCRtpEncodingParameters looked like this:

dictionary RTCRtpEncodingParameters {
unsigned long ssrc;
payloadtype codecPayloadType;
RTCRtpFecParameters fec;
RTCRtpRtxParameters rtx;
double priority = 1.0;
unsigned long long maxBitrate;
double minQuality = 0;
double framerateBias = 0.5;
double resolutionScale;
double framerateScale;
boolean active = true;
DOMString encodingId;
sequence dependencyEncodingIds;
};

Issue 249 (#249) deals with the change of priority from a double to RTCPriorityType.

In WebRTC 1.0, it is also proposed to replace double framerateBias with RTCDegradationPreference degradationPreference (and move it to RTCRtpParameters), where:

enum RTCDegradationPreference {
"maintain-framerate",
"maintain-resolution",
"balanced"
};

As a result of the changes, RTCRtpEncodingParameters would look like this:

dictionary RTCRtpEncodingParameters {
unsigned long ssrc;
payloadtype codecPayloadType;
RTCRtpFecParameters fec;
RTCRtpRtxParameters rtx;
RTCPriorityType priority;
unsigned long maxBitrate;
double minQuality = 0;
double resolutionScale;
double framerateScale;
boolean active = true;
DOMString encodingId;
sequence dependencyEncodingIds;
};

and RTCRtpParameters would look like this:

dictionary RTCRtpParameters {
DOMString muxId = "";
sequence codecs;
sequence headerExtensions;
sequence encodings;
RTCRtcpParameters rtcp;
RTCDegradationPreference degradationPreference = "balanced";
};

@aboba
Copy link
Contributor Author

@aboba aboba commented Nov 6, 2015

Here is the PR in WebRTC 1.0 to move degradationPreference to RTCRtpParameters:
w3c/webrtc-pc#397

@aboba aboba changed the title Meaning of framerateBias for Simulcast RTCDegradationPreference and RTCPriorityType Nov 20, 2015
@aboba aboba changed the title RTCDegradationPreference and RTCPriorityType RTCDegradationPreference Nov 20, 2015
@aboba aboba closed this Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant