New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples 6, 7, 22 and 24 are wrong #310
Comments
Some issue in Example 7: // Create the DTLS certificate
var keygenAlgorithm = { name: "ECDSA", namedCurve: "P-256" };
RTCCertificate.generateCertificate(keygenAlgorithm).then(function(certificate){
var cert = certificate;
}, function(){
trace('Certificate could not be created');
});
// Create ICE and DTLS transports
var ice = new RTCIceTransport(iceGatherer);
var dtls = new RTCDtlsTransport(ice, cert); // `cert` does not exist in this scope. |
If I do not miss anything I will send a PR next week, |
PR for this issue: #312 |
Great, didn't see the PR. |
This was referenced Jan 2, 2016
Found similar problems in Examples 22 and 24. PR submitted to fix those as well as some respec errors: #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
var dtlsTransport = new RTCDtlsTransport(iceTransport, cert);
such acert
variable does not exist in that scope. It was defined in theresolve
function of theRTCCertificate.generateCertificate()
returned Promise.For this to be valid,
var cert
should be declared above theRTCCertificate.generateCertificate()
call.The text was updated successfully, but these errors were encountered: