New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDtlsTransportState due to common Close Alert. #327

Closed
ibc opened this Issue Jan 5, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ibc
Copy link
Contributor

ibc commented Jan 5, 2016

Let's have an already established/connected DTLS connection (state = connected). The remote peer closes its side so sends a signaling "BYE" and also a DTLS Close Alert. Usually the DTLS Close Alert arrives before to us.

In this scenario (a common Close Alert rather than an "error"), what would be our RTCDtlsTransportState upon receipt of such a Close Alert? According to the spec it would become failed:

closed
The DTLS connection has been closed intentionally via a call to stop(). Calling transport.stop() will also result in a transition to the "closed" state.

failed
The DTLS connection has been closed as the result of an error (such as a DTLS alert or a failure to validate the remote fingerprint).

But that would trigger a RTCDtlsTransportStateChangedEvent and the app would be notified about a DTLS "failure" and would act according (for example by displaying a warning message to the user or whatever), but after a few milliseconds the signaling "BYE" will arrive, invalidating such a warning.

So, would not make sense that, in this scenario in which we receive a DTLS Close Alert within a correctly connected DTLS transport, our RTCDtlsTransportState becomes closed instead of failed?

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Jan 6, 2016

I agree that RTCDtlsTransportState should transition to "closed" on receipt of a Close Alert, rather than "failed".

aboba added a commit that referenced this issue Jan 6, 2016

@aboba aboba added PR exists and removed publication-blocker labels Jan 6, 2016

ibc added a commit to versatica/mediasoup that referenced this issue Jan 6, 2016

@aboba aboba closed this Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment