New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can rtpReceiver.rtcpTransport retrieve null? #349

Closed
ibc opened this Issue Jan 14, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ibc
Copy link
Contributor

ibc commented Jan 14, 2016

var transport = new RTCDtlsTransport(...);
var rtpReceiver = new RTCRtpReceiver(transport);

rtpReceiver.transport;
// => transport

rtpReceiver.rtcpTransport;
// => transport or null or undefined?
@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Jan 18, 2016

I believe that rtcpTransport should be unset in this case since an rtcpTransport was not supplied in the constructor.

@ibc

This comment has been minimized.

Copy link
Contributor

ibc commented Jan 18, 2016

Another approach would be for the getter to retrieve the effective RTCDtlsTransport, which at the end is the given transport.

IMHO it should be clarified in the spec.

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Jan 19, 2016

Just found the corresponding text in WebRTC 1.0.

Section 5.2.1 (RTCRtpSender)

The rtcpTransport attribute is the transport over which RTCP is sent and received. When BUNDLE is used, many RTCRtpSender objects will share one rtcpTransport and will all send and receive RTCP over the same transport. When RTCP mux is used, rtcpTransport will be null, and both RTP and RTCP traffic will flow over the transport described by transport.

Section 5.3.1 (RTCRtpReceiver)

The RTCRtpReceiver.rtcpTransport attribute is the transport over which RTCP is sent and received. When BUNDLE is used, many RTCRtpReceiver objects will share one RTCRtpReceiver.rtcpTransport and will all send and receive RTCP over the same transport. When RTCP mux is used, RTCRtpReceiver.rtcpTransport will be null, and both RTP and RTCP traffic will flow over RTCRtpReceiver.transport.

@ibc

This comment has been minimized.

Copy link
Contributor

ibc commented Jan 19, 2016

Clear. Thanks.

aboba added a commit that referenced this issue Jan 19, 2016

Can rtpReceiver.rtcpTransport retrieve null?
Sync definitions of RTCRtpReceiver.rtcpTransport and RTCRtpReceiver.rtcpTransport with WebRTC 1.0. 

Fix for Issue #349

@aboba aboba added PR exists and removed publication-blocker labels Jan 19, 2016

@aboba aboba closed this Jan 20, 2016

@aboba aboba reopened this Jan 20, 2016

@aboba aboba closed this Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment