New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Issues in the Editor's draft #37

Closed
aboba opened this Issue Mar 7, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@aboba
Copy link
Contributor

aboba commented Mar 7, 2014

Some issues in the editor's draft:
http://ortc.org/wp-content/uploads/2014/02/ortc.html
URL: http://lists.w3.org/Archives/Public/public-orca/2014Mar/0000.html

(1) No definition of RTCIceParameters and RTCDtlsParameters

(2)
example 3
var ice = new RTCIceTransport(iceOptions); // where is the role parameter?

(3)
RTCIceCandidate example is out of date with connectionAddress and connectionPort
{
foundation: "abcd1234",
priority: 1694498815,
connectionAddress: "192.0.2.33",
connectionPort: 10000,
type: "host"
};

(4)
// readonly attributes for track and transport below ?
[Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpSender {
attribute MediaStreamTrack track;
attribute RTCDtlsTransport transport;
[Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpReceiver {
attribute MediaStreamTrack? track;
attribute RTCDtlsTransport transport;

(5)
// typo "sending" should be "receiving" below
An RTCRtpReceiver instance is associated to a sending MediaStreamTrack

(6)
In example 8,
// The responder answers with parameters it wants to send with
// and the capabilities it has for receiving.
audioSendParams = RTCRtpSender.filterParameters(
sendAudioParams, answer.rtpCaps);
videoSendParams = RTCRtpSender.filterParameters(
sendVideoParams, answer.rtpCaps
var audioRecvParams = RTCRtpSender.filterParameters(
answer.audio);
var videoRecvParams = RTCRtpSender.filterParameters(
answer.video);
should be ?
// The responder answers with parameters it wants to send with
// and the capabilities it has for receiving.
audioSendParams = RTCRtpSender.filterParameters(
sendAudioParams, answer.rtpCaps);
videoSendParams = RTCRtpSender.filterParameters(
sendVideoParams, answer.rtpCaps
var audioRecvParams = RTCRtpReceiver.filterParameters(
answer.audio);
var videoRecvParams = RTCRtpReceiver.filterParameters(
answer.video);

In example 9,
var audioSendParams = RTCRtpSender.createParameters(
audioTrack, remote.rtpCaps);
var videoSendParams = RTCRtpSender.createParameters(
videoTrack, remote.rtpCaps);
var audioRecvParams = RTCRtpSender.filterParameters(
remote.audio);
var videoRecvParams = RTCRtpSender.filterParameters(
remote.video);
should be ?
var audioSendParams = RTCRtpSender.createParameters(
audioTrack, remote.rtpCaps);
var videoSendParams = RTCRtpSender.createParameters(
videoTrack, remote.rtpCaps);
var audioRecvParams = RTCRtpReceiver.filterParameters(
remote.audio);
var videoRecvParams = RTCRtpReceiver.filterParameters(
remote.video);

(7)
In [Constructor(MediaStreamTrack track, RTCDtlsTransport transport)]
interface RTCRtpReceiver {

track should not be there for the receiver. Example 8 and example 9 do not have track in constructor:
...
var audioReceiver = new RTCRtpReceiver(transport);
var videoReceiver = new RTCRtpReceiver(transport);
...
var audioReceiver = new RTCRtpReceiver(transport);
var videoReceiver = new RTCRtpReceiver(transport);
...

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Apr 4, 2014

Items 1-3 are ok. In Item 4, both track and transport are in fact readonly in RTCRtpSender; for RTCRtpReceiver the track is readonly.

The examples need to be rewritten anyway; let's leave that until the API is more complete.

@aboba aboba closed this Apr 4, 2014

robin-raymond pushed a commit to robin-raymond/ortc that referenced this issue Apr 12, 2014

Robin Raymond
Support for contributing source information added, as described in w3…
…c#27

Support for control of quality, resolution, framerate and layering added, as described inhttps://github.com/w3c/issues/31
RTCRtpListener object added and figure in Section 1 updated, as described in w3c#32
More complete support for RTP and Codec Parameters added, as described in w3c#33
Data Channel transport problem fixed, as described in w3c#34
Various NITs fixed, as described in w3c#37
Section 2.2 and 2.3 issues fixed, as described in w3c#38
Default values of some dictionary attributes added, to partially address the issue described in w3c#39
Support for ICE TCP added, as described in w3c#41
Fixed issue with sequences as attributes, as described in w3c#43
Fix for issues with onlocalcandidate, as described in w3c#44
Initial stab at a Stats API, as requested in w3c#46
Added support for ICE gather policy, as described in w3c#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment