New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ongathererstatechange vs onstatechange #475

Closed
robin-raymond opened this Issue Apr 19, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@robin-raymond
Contributor

robin-raymond commented Apr 19, 2016

WebRTC names these events with ongathererstatechange vs just onstatechange because these all hang off a bigger peer connection object. ORTC however does not.

This should change from:

partial interface RTCIceGatherer : RTCStatsProvider {
                    attribute EventHandler?       ongathererstatechange;
}

To:

partial interface RTCIceGatherer : RTCStatsProvider {
                    attribute EventHandler?       onstatechange;
}

@robin-raymond robin-raymond added the 1.1 label Apr 19, 2016

@ibc

This comment has been minimized.

Show comment
Hide comment
@ibc

ibc Apr 19, 2016

Contributor

Sure.

Contributor

ibc commented Apr 19, 2016

Sure.

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 19, 2016

Contributor

Change:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onicestatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
}

To:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onstatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
                    attribute EventHandler?        onstatechange;
}
Contributor

robin-raymond commented Apr 19, 2016

Change:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onicestatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
}

To:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onstatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
                    attribute EventHandler?        onstatechange;
}

aboba added a commit that referenced this issue Apr 20, 2016

@aboba aboba added the PR exists label Apr 20, 2016

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 20, 2016

Contributor

Yes, that PR fixes. Merged + closing.

Contributor

robin-raymond commented Apr 20, 2016

Yes, that PR fixes. Merged + closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment