ongathererstatechange vs onstatechange #475

Closed
robin-raymond opened this Issue Apr 19, 2016 · 3 comments

Projects

None yet

3 participants

@robin-raymond
Contributor

WebRTC names these events with ongathererstatechange vs just onstatechange because these all hang off a bigger peer connection object. ORTC however does not.

This should change from:

partial interface RTCIceGatherer : RTCStatsProvider {
                    attribute EventHandler?       ongathererstatechange;
}

To:

partial interface RTCIceGatherer : RTCStatsProvider {
                    attribute EventHandler?       onstatechange;
}
@robin-raymond robin-raymond added the 1.1 label Apr 19, 2016
@ibc
Contributor
ibc commented Apr 19, 2016

Sure.

@robin-raymond
Contributor

Change:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onicestatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
}

To:

partial interface RTCIceTransport : RTCStatsProvider {
                    attribute EventHandler?        onstatechange;
}

partial interface RTCDtlsTransport : RTCStatsProvider  {
                    attribute EventHandler?        onstatechange;
}
@aboba aboba added a commit that referenced this issue Apr 20, 2016
@aboba aboba ongathererstatechange vs onstatechange
Fix for Issue #475
a0a4a63
@aboba aboba added the PR exists label Apr 20, 2016
@robin-raymond
Contributor

Yes, that PR fixes. Merged + closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment