New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE supper nitty - usernameFragment, etc #485

Closed
robin-raymond opened this Issue Apr 21, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@robin-raymond
Contributor

robin-raymond commented Apr 21, 2016

usernameFragment of type DOMString
ICE username.

It's not a username, it's a username fragment. I know i'm being nitty...

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 21, 2016

Contributor

And another:

The local RTCIceParameters object includes the ICE username fragment and password.

Should read:

The local RTCIceParameters object includes the ICE username fragment and password and other ICE related parameters.

Because ICE lite is another option so it's not technically true.

Contributor

robin-raymond commented Apr 21, 2016

And another:

The local RTCIceParameters object includes the ICE username fragment and password.

Should read:

The local RTCIceParameters object includes the ICE username fragment and password and other ICE related parameters.

Because ICE lite is another option so it's not technically true.

@robin-raymond robin-raymond changed the title from usernameFragment to ICE supper nitty - usernameFragment Apr 21, 2016

@robin-raymond robin-raymond changed the title from ICE supper nitty - usernameFragment to ICE supper nitty - usernameFragment, etc Apr 21, 2016

@aboba

This comment has been minimized.

Show comment
Hide comment
@aboba

aboba Apr 21, 2016

Contributor

@robin-raymond Only the remote RTCIceParameters object can include the ICE lite option.

Contributor

aboba commented Apr 21, 2016

@robin-raymond Only the remote RTCIceParameters object can include the ICE lite option.

aboba added a commit that referenced this issue Apr 21, 2016

ICE nits
Fix for Issue #485

@aboba aboba referenced this issue Apr 21, 2016

Merged

ICE nits #487

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 21, 2016

Contributor

Better.

Contributor

robin-raymond commented Apr 21, 2016

Better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment