New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCRtpCodecParameters clock rate nullable? #500

Closed
robin-raymond opened this Issue Apr 24, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@robin-raymond
Contributor

robin-raymond commented Apr 24, 2016

clockRate of type unsigned long
Codec clock rate expressed in Hertz, null if unset.

It's not nullable. I think it should just say:

Codec clock rate expressed in Hertz; clock rate is defaulted if unset.

... or something like that....

@aboba aboba added the 1.1 label Apr 25, 2016

@aboba

This comment has been minimized.

Show comment
Hide comment
@aboba

aboba Apr 25, 2016

Contributor

Related to Issue #503

Can we say that it would default to the value included in RTCRtpCodecCapability.clockRate ?

Contributor

aboba commented Apr 25, 2016

Related to Issue #503

Can we say that it would default to the value included in RTCRtpCodecCapability.clockRate ?

aboba added a commit that referenced this issue Apr 25, 2016

@aboba aboba added the PR exists label Apr 25, 2016

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 25, 2016

Contributor

Better.

Contributor

robin-raymond commented Apr 25, 2016

Better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment