dictionary RTCDataChannelParameters id is null and other "null if unset"? #503

Closed
robin-raymond opened this Issue Apr 25, 2016 · 3 comments

Projects

None yet

2 participants

@robin-raymond
Contributor

id of type unsigned short
The id attribute returns the id for this RTCDataChannel, or null if unset.

... id isn't nullable so that should say it's null if unset.

@robin-raymond robin-raymond changed the title from dictionary RTCDataChannelParameters id is null? to dictionary RTCDataChannelParameters id is null and other "null if unset"? Apr 25, 2016
@robin-raymond
Contributor

There are a number of instances of "null if unset" throughout the document.

@aboba
Contributor
aboba commented Apr 25, 2016

"null if unset" is used in the following dictionary definitions:

RTCRtpCodecParameters dictionary, clockRate attribute (near line 3326)
RTCDataChannelParameters dictionary, maxPacketLifetime attribute (near line 5084)
RTCDataChannelParameters dictionary, maxRetransmits attribute (near line 5094)
RTCDataChannelParameters dictionary, id attribute (near line 5128)

@aboba aboba added a commit that referenced this issue Apr 25, 2016
@aboba aboba Remove "null if unset"
Fix for Issue #503
2ef345b
@aboba aboba added the PR exists label Apr 25, 2016
@robin-raymond
Contributor

Good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment