Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dictionary RTCDataChannelParameters id is null and other "null if unset"? #503

Closed
robin-raymond opened this issue Apr 25, 2016 · 3 comments
Closed

dictionary RTCDataChannelParameters id is null and other "null if unset"? #503

robin-raymond opened this issue Apr 25, 2016 · 3 comments
Labels
1.0 compatibility issue 1.1 PR exists

Comments

@robin-raymond
Copy link
Contributor

id of type unsigned short
The id attribute returns the id for this RTCDataChannel, or null if unset.

... id isn't nullable so that should say it's null if unset.
@robin-raymond robin-raymond changed the title dictionary RTCDataChannelParameters id is null? dictionary RTCDataChannelParameters id is null and other "null if unset"? Apr 25, 2016
@robin-raymond
Copy link
Contributor Author

There are a number of instances of "null if unset" throughout the document.

@aboba
Copy link
Contributor

aboba commented Apr 25, 2016

"null if unset" is used in the following dictionary definitions:

RTCRtpCodecParameters dictionary, clockRate attribute (near line 3326)
RTCDataChannelParameters dictionary, maxPacketLifetime attribute (near line 5084)
RTCDataChannelParameters dictionary, maxRetransmits attribute (near line 5094)
RTCDataChannelParameters dictionary, id attribute (near line 5128)

@aboba aboba mentioned this issue Apr 25, 2016
Closed
aboba added a commit that referenced this issue Apr 25, 2016
@aboba
Remove "null if unset"
2ef345b 
Fix for Issue #503
@aboba aboba mentioned this issue Apr 25, 2016
Merged
@robin-raymond
Copy link
Contributor Author

Good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 compatibility issue 1.1 PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond