New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary RTCDataChannelParameters id is null and other "null if unset"? #503

Closed
robin-raymond opened this Issue Apr 25, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@robin-raymond
Contributor

robin-raymond commented Apr 25, 2016

id of type unsigned short
The id attribute returns the id for this RTCDataChannel, or null if unset.

... id isn't nullable so that should say it's null if unset.

@robin-raymond robin-raymond changed the title from dictionary RTCDataChannelParameters id is null? to dictionary RTCDataChannelParameters id is null and other "null if unset"? Apr 25, 2016

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 25, 2016

Contributor

There are a number of instances of "null if unset" throughout the document.

Contributor

robin-raymond commented Apr 25, 2016

There are a number of instances of "null if unset" throughout the document.

@aboba

This comment has been minimized.

Show comment
Hide comment
@aboba

aboba Apr 25, 2016

Contributor

"null if unset" is used in the following dictionary definitions:

RTCRtpCodecParameters dictionary, clockRate attribute (near line 3326)
RTCDataChannelParameters dictionary, maxPacketLifetime attribute (near line 5084)
RTCDataChannelParameters dictionary, maxRetransmits attribute (near line 5094)
RTCDataChannelParameters dictionary, id attribute (near line 5128)

Contributor

aboba commented Apr 25, 2016

"null if unset" is used in the following dictionary definitions:

RTCRtpCodecParameters dictionary, clockRate attribute (near line 3326)
RTCDataChannelParameters dictionary, maxPacketLifetime attribute (near line 5084)
RTCDataChannelParameters dictionary, maxRetransmits attribute (near line 5094)
RTCDataChannelParameters dictionary, id attribute (near line 5128)

@robin-raymond

This comment has been minimized.

Show comment
Hide comment
@robin-raymond

robin-raymond Apr 25, 2016

Contributor

Good now.

Contributor

robin-raymond commented Apr 25, 2016

Good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment