RTCDataChannelParameters issues #519

Closed
aboba opened this Issue Apr 26, 2016 · 1 comment

Projects

None yet

2 participants

@aboba
Contributor
aboba commented Apr 26, 2016

partial interface RTCDataChannel : EventTarget {
readonly attribute RTCDataChannelParameters parameters;
}

[BA] This is illegal in WebIDL. Should be replaced by:

RTCDataChannelParameters getParameters();

In Example 23:

// Construct RTCDataChannelParameters object
var parameters = new RTCDataChannelParameters();

[BA] This is not correct, since RTCDataChannelParameters is a dictionary, not an object. Should be:

var parameters = {
label: "",
ordered: true,
maxPacketLifetime: ,
maxRetransmits: ,
protocol: "",
negotiated: false,
id:
};

@aboba aboba added the 1.1 label Apr 26, 2016
@aboba aboba added a commit that referenced this issue Apr 26, 2016
@aboba aboba RTCDataChannelParameters Issues
Fix for Issue #519

Work-in-progress (please do not merge)
8b3da12
@aboba aboba added the PR exists label Apr 26, 2016
@robin-raymond
Contributor

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment