Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDataChannelParameters issues #519

Closed
aboba opened this issue Apr 26, 2016 · 1 comment
Closed

RTCDataChannelParameters issues #519

aboba opened this issue Apr 26, 2016 · 1 comment

Comments

@aboba
Copy link
Contributor

aboba commented Apr 26, 2016

partial interface RTCDataChannel : EventTarget {
readonly attribute RTCDataChannelParameters parameters;
}

[BA] This is illegal in WebIDL. Should be replaced by:

RTCDataChannelParameters getParameters();

In Example 23:

// Construct RTCDataChannelParameters object
var parameters = new RTCDataChannelParameters();

[BA] This is not correct, since RTCDataChannelParameters is a dictionary, not an object. Should be:

var parameters = {
label: "",
ordered: true,
maxPacketLifetime: ,
maxRetransmits: ,
protocol: "",
negotiated: false,
id:
};

@aboba aboba added the 1.1 label Apr 26, 2016
aboba added a commit that referenced this issue Apr 26, 2016
Fix for Issue #519

Work-in-progress (please do not merge)
@robin-raymond
Copy link
Contributor

robin-raymond commented Apr 28, 2016

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants