Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify FEC codec names #544

Closed
ibc opened this issue May 16, 2016 · 2 comments
Closed

Specify FEC codec names #544

ibc opened this issue May 16, 2016 · 2 comments

Comments

@ibc
Copy link
Contributor

ibc commented May 16, 2016

In RtpSender.send():

if withParameters.codecs[j].name is equal to "red", "cn", "dtmf", "rtx" or a forward error correction codec, return a promise rejected with InvalidParameters.

May the spec specify the exact "forward error correction codec" names? AFAIK they can be "fec" and "ulpfec", right? If so, please make the spec specify them.

@aboba
Copy link
Contributor

aboba commented May 16, 2016

I think the MIME subtypes are "ulpfec" (from https://tools.ietf.org/html/rfc5109#page-31) and "flexfec" from https://tools.ietf.org/html/draft-ietf-payload-flexible-fec-scheme-02#page-17

@ibc
Copy link
Contributor Author

ibc commented May 16, 2016

Yep, I've realized of that right now :)

However I propose that the spec becomes much clearer when it comes to IANA names.

aboba added a commit that referenced this issue May 19, 2016
@aboba aboba closed this as completed May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants