New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE restart needed #59

Closed
robin-raymond opened this Issue Apr 14, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@robin-raymond
Copy link
Contributor

robin-raymond commented Apr 14, 2014

Need a way to do ICE restart, proposal is:

  1. setRemoteCandidates with empty list, effectively disconnects ICE, allows you to change local priorities because not in discovery mode
  2. setRemoteCandidates with full list after causes fresh checks to restart over again
@martinthomson

This comment has been minimized.

Copy link
Member

martinthomson commented Apr 14, 2014

I'm not convinced that this is needed. I can see how it might be wanted, but not needed.

But if it is included, tweaks on the remote side won't have the desired effect. Changes need to be local too. In a restart, as defined by 5245, the local ufrag and pwd change. To do that, maybe you should make a new ICEListener and push that in somehow.

@robin-raymond robin-raymond added the 1.1 label Apr 29, 2014

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Apr 29, 2014

Discussion was held here: http://lists.w3.org/Archives/Public/public-ortc/2014Apr/0127.html

And decision (thus far) is that nothing is truly needed to add to API surface. Create "brand new" RTCIceListener/RTCIceTransport pair to do restart.

We should have an example of ICE restart in specification somewhere.

robin-raymond pushed a commit to robin-raymond/ortc that referenced this issue May 14, 2014

Robin Raymond
- ICE restart explanation added, as described in Issue 59
w3c#59

-Fixes for error handling, as described in Issue 75
w3c#75

- Fixes for miscellaneous NITs, as described in Issue 76
w3c#76

- Enable retrieval of the SSRC to be used by RTCP, as described in Issue 77
w3c#77

- Support for retrieval of audio and video capabilities, as described in Issue 81
w3c#81

- getStats interface updated, as described in Issue 82
w3c#82

- Partially addressed SVC issues described in Issue 83
w3c#83

- Partially addressed statistics update issues described in Issue 85
w3c#85
@juberti

This comment has been minimized.

Copy link

juberti commented May 15, 2014

I don't think this is sufficient given the need for TransportController and freezing policy. The TransportController really needs to be able to redo its thing, suggesting that ICE restart needs to be internal to an IceTransport rather than configured externally. (Unless we want to go down the route of having multiple TCs, which starts getting into questionable territory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment