State Transitions for RTCIceGatherer #606

Closed
lgrahl opened this Issue Oct 6, 2016 · 4 comments

Projects

None yet

3 participants

@lgrahl
lgrahl commented Oct 6, 2016

In the RTCIceGatherer interface, state transition is not well defined. For example: Can a closed gatherer go back to gathering? A state transition diagram would probably help.

Furthermore, the gather method of the RTCIceGatherer does not clarify in which state it can be called without raising an error.

@aboba aboba added the 1.1 label Oct 25, 2016
@aboba
Contributor
aboba commented Oct 25, 2016

I do not believe that an IceGatherer in the "closed" state can transition to another state (e.g. "closed" is terminal). Also, in the "closed" state, calls to gather(), getLocalParameters(), getLocalCandidates() and createAssociatedGatherer() should cause an InvalidStateError exception to be thrown.

@aboba aboba added a commit that referenced this issue Oct 25, 2016
@aboba aboba State Transitions for RTCIceGatherer
Fix for #606
6bd87e8
@aboba aboba added the PR exists label Oct 25, 2016
@aboba aboba self-assigned this Oct 25, 2016
@robin-raymond
Contributor

Yes, closed is terminal.

@robin-raymond
Contributor

gather() can called from any state except closed - I think.

@robin-raymond
Contributor

We should be clear that closed state can only happen by manual programmer intervention and it cannot happen automatically.

@aboba aboba closed this Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment